Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY]: Display upload series on validation results page #327

Open
ClaireValdivia opened this issue Jun 13, 2024 · 0 comments
Open

[STORY]: Display upload series on validation results page #327

ClaireValdivia opened this issue Jun 13, 2024 · 0 comments

Comments

@ClaireValdivia
Copy link

ClaireValdivia commented Jun 13, 2024

Why is this issue important?

As an agency or staff user, when I view an upload results page, I want to see the related series of uploads for the relevant agency, EC Code, and reporting period so I can quickly understand which upload will be referenced by the audit & treasury report.

Current State

The Upload page only contains information about the specific file that was uploaded and not the related series.

Expected State

Below the current "Upload Details" section on the upload page, the following will display

Title:
The title should display the following text in the same font & size as the "Upload Details" header: "Upload Series from Agency Name EC Code EC Code Number in period Reporting Period Name
Ex: "Upload Series from Ohio OMB EC Code 1A in period Q3 2024

Summary
Under the title, the following should display in body text formatting

  • if the agency/code/reporting period combination has a valid uploads, the following text should display: "The upload highlighted in green will be used for Treasury Reporting."
  • if the agency/code/reporting period combination has no valid uploads, the following text should display: "Agency Agency Name does not have a valid upload with code EC Code Number to use in Treasury reporting for reporting period name

Upload Series Table
Beneath the summary, a table should display.

  • it should mirror the table formatting of the Subrecipients table,
  • sorting and searching should be disabled for all columns.
  • the table should display all uploads that match the agency, EC code, and reporting period (regardless of whether it is validated or now). each row should represent one upload
  • The rows should display in order of upload (most recent displaying first, oldest at the bottom)
  • The row with the most recent valid upload (if one exists for the series) should be shaded in green
  • the table should have the following columns:
    • ID - this should display the ID number with a link to the uploads page within the tool (i.e. same as the "ID" column on the main Uploads page table.
    • Validated? - should display the same content as "Validated?" column on main uploads tab, including font colors
  • the row that displays the upload page that the user is on, the ID cell for that upload should not be a link and just display the text of the ID number, and "(this upload)" should display next to the id number in the ID cell

These are mockups, but note that they do not reflect the exact font, colors, or table formatting:

Image

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

@ClaireValdivia ClaireValdivia moved this from 🆕 New to 📋 Scoping in Grants Team Agile Planning Jul 24, 2024
@greg-adams greg-adams self-assigned this Oct 17, 2024
@greg-adams greg-adams moved this from 🔖 Ready to 🏗 In progress in Grants Team Agile Planning Oct 21, 2024
@greg-adams greg-adams moved this from 🏗 In progress to 👀 In review in Grants Team Agile Planning Oct 22, 2024
@as1729 as1729 assigned as1729 and unassigned greg-adams Nov 19, 2024
as1729 pushed a commit that referenced this issue Dec 11, 2024
* add upload series table

* add tests

* remove unused

* merge conflict resolution

---------

Co-authored-by: Sushil Rajeeva Bhandary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready
Development

No branches or pull requests

4 participants