USAGOV-2179: PXBF release v0.9.0.beta.1

[scottqueen-bixal]

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-

Description

Benefit Finder Release v0.9.0
https://github.com/GSA/px-benefit-finder/releases/tag/v0.9.0.beta.1

Related Github Issue

https://github.com/GSA/px-benefit-finder/milestone/15?closed=1

Design Updates

Design | Mobile Layout Updates GSA/px-benefit-finder#1954
Design and content changes to the Landing Page of the Benefit Finder GSA/px-benefit-finder#1897
Redesign | Container widths GSA/px-benefit-finder#1778
Redesign | Mobile Typography GSA/px-benefit-finder#1776
Mobile Screens | Accordion Results GSA/px-benefit-finder#1839

Application updates

Function added to the BF Accordion Cards "More info needed" GSA/px-benefit-finder#1975
flashing button group on re-render GSA/px-benefit-finder#1996

Custom Module Improvements

Remove Criteria Group GSA/px-benefit-finder#1492
Prevent content developer from creating nested parent child relationships GSA/px-benefit-finder#1850
Remove role attribute GSA/px-benefit-finder#1979

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • WWW
  • Egress
  • Tools
  • Cron
• Other

Testing Instructions

Detailed Testing steps

Design Updates

Design updates were reviewed and approved by USAGov and Benefit Finder Design team duirng the Benefit Finder QA sprint

Application updates

Function added to the BF Accordion Cards "More info needed" GSA/px-benefit-finder#1975

• navigate to /benefit-finder/death

• provide required values
• navigate to list of benefit accordions
• ensure that any of the following conditionals results in rendering the "Go back to start" cta

1. not-eligible view in the more info needed accordions
2. not-eligible view in the not-eligible accordions that also have more info needed listed

• when clicked the user should be navigated back to the first step of the form with the previous selections still in value

flashing button group on re-render GSA/px-benefit-finder#1996

• Fixes USAGOV-1103: Check what are these IPs for in Firewall rules. #1996

Detailed Testing steps

• navigate to final step of form
• toggle values in fieldset
• ensure button group does not "flash"

previous:

Screen.Recording.2024-12-10.at.11.34.02.AM.mov

expected update:

Screen.Recording.2024-12-16.at.2.16.27.PM.mov

Custom Module Improvements

Remove Criteria Group GSA/px-benefit-finder#1492

• If in local, bin/drush cim
• Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
• Go to life event form "Benefit finder: death of a loved one" edit page
• Go to criteria "Applicant date of birth"
• Verify no Add criteria group button in criteria

• Go to "Deceased service status"
• Verify no Add criteria group button in children of criteria

Prevent content developer from creating nested parent child relationships GSA/px-benefit-finder#1850

• Navigate to node/add
• Click Add Criteria to add a criteria as following
• Title: depth 0 criteria
• Criteria Key: depth_0_criteria
• ID: depth_0_criteria
• Type: Boolean
• Label: Depth 0 criteria
• Name: Depth 0 criteria
• Values: 1) Yes 2) No
• Check Has Child
• Input Yes in Child dependency options
• Click Save as Published

• Follow same steps to create depth 1, depth 2, and depth 3 criteria
• Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
• Go to life event form "Benefit finder: death of a loved one" edit page
• Go to section "About you" to add criteria "depth 0 criteria"
• Add criteria "depth 1 criteria" as child of "depth 0 criteria"
• Add criteria "depth 2 criteria" as child of "depth 1 criteria"
• Add criteria "depth 3 criteria" as child of "depth 2 criteria"

• Click Save
• Verify error message about criteria depth >1

Remove role attribute GSA/px-benefit-finder#1979

• Navigate to benefit-finder/death
• Inspect
• Verify no role attribute in header and main

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Test instruction 1
• Test instruction 2
• Test instruction 3

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[gchi25]

Tested. Worked as expected.

[akf]

Looks fine

[ErnestoFernandezAlvarez]

The design QA was completed today. I went over the item as a result of the December QA for the Mobile design.
Note: today we discussed adding a ticket to review the check mark size (inside the accordions).

On the client side I marked all the open tickets as resolved.
Thank you @scottqueen-bixal