-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show active jobs in the build status #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - just a couple comments.
- name: Generate List of Crossbow Tasks | ||
run: | | ||
python -m pip install -e arrow/dev/archery[crossbow] | ||
archery crossbow check-config > crossbow/all.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 - wonderful.
tasks <- yaml.load_file("all.yml") | ||
|
||
tests <- tasks$groups[["nightly-tests"]] | ||
packaging <- tasks$groups[["nightly-packaging"]] | ||
release <- tasks$groups[["nightly-release"]] | ||
nightly_regex <- paste0(c(tests, packaging, release), collapse = "|") | ||
|
||
active_jobs <- tasks$tasks %>% names() %>% grep(nightly_regex, x = ., value = TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be done now (i.e. could be a TODO) but it would be nice to wrap this (and other code in this report) into functions and do some testing. I can take that on in a subsequent PR if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good — I don't have any additional comments beyond what Sam mentioned below
As discussed on zulip we want to have a more future proof version than manually adding job names to filter out.