Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show active jobs in the build status #53

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Conversation

assignUser
Copy link
Contributor

As discussed on zulip we want to have a more future proof version than manually adding job names to filter out.

@assignUser
Copy link
Contributor Author

@boshek @jonkeane what do you think? I also added a step that uploads the rendered dashboard as an artifact so we caniterate easier :)

Copy link
Contributor

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - just a couple comments.

- name: Generate List of Crossbow Tasks
run: |
python -m pip install -e arrow/dev/archery[crossbow]
archery crossbow check-config > crossbow/all.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 - wonderful.

Comment on lines +230 to +237
tasks <- yaml.load_file("all.yml")

tests <- tasks$groups[["nightly-tests"]]
packaging <- tasks$groups[["nightly-packaging"]]
release <- tasks$groups[["nightly-release"]]
nightly_regex <- paste0(c(tests, packaging, release), collapse = "|")

active_jobs <- tasks$tasks %>% names() %>% grep(nightly_regex, x = ., value = TRUE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be done now (i.e. could be a TODO) but it would be nice to wrap this (and other code in this report) into functions and do some testing. I can take that on in a subsequent PR if you like.

Copy link
Collaborator

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good — I don't have any additional comments beyond what Sam mentioned below

@assignUser assignUser marked this pull request as ready for review January 4, 2023 16:54
@assignUser assignUser merged commit 0b47a80 into master Jan 4, 2023
@ursabot ursabot deleted the remove-old-jobs branch April 5, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants