You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello.
I try to use frser for esp8266 platform.
As I see the api is a bit painful to apply it directly there.
For eg. If this library try to be portable as possible each function should have a prefix like frser_*
Otherwise we can have already function called like spi_init()
Also in I notice that udalay.c we have _delay_us what is a avr specific name.I know its a week reference but still...
Also IMHO instead using preprocessor directives #defined RECEIVE() .. etc and include files like uart.h main.h etc, we should have a single file like frser_api.h where all api function can be defined for eg as extern and then used in external project.
Currently its not possible to don`t have header files like uart.h, so again this lib should use name prefix for such file or all api should be in frser_api.h/c
Best Regards.
The text was updated successfully, but these errors were encountered:
hetii
changed the title
Namespace for function.
Namespace for function and header files.
May 9, 2016
-- for future reference --
22:56 hetii: btw, i'd rather take concrete pull requests (and also ruthlessly close them if i dont like them :P) rather than wishywashy structural issues
22:56 i know it isnt perfect, no reason to bother me about it :P
22:57 but yes, one could rename spi_init ... though it's only used by spilib (and the AVR SPI driver), and nobody forces you to use either of them
...
I guess I'll leave this open for now, but...
Hello.
I try to use frser for esp8266 platform.
As I see the api is a bit painful to apply it directly there.
For eg. If this library try to be portable as possible each function should have a prefix like frser_*
Otherwise we can have already function called like spi_init()
Also in I notice that udalay.c we have _delay_us what is a avr specific name.I know its a week reference but still...
Also IMHO instead using preprocessor directives
#defined RECEIVE() ..
etc and include files like uart.h main.h etc, we should have a single file like frser_api.h where all api function can be defined for eg asextern
and then used in external project.Currently its not possible to don`t have header files like uart.h, so again this lib should use name prefix for such file or all api should be in frser_api.h/c
Best Regards.
The text was updated successfully, but these errors were encountered: