Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Street Eats codealong, refactor props #7

Open
twant opened this issue Oct 18, 2019 · 0 comments
Open

In the Street Eats codealong, refactor props #7

twant opened this issue Oct 18, 2019 · 0 comments
Assignees

Comments

@twant
Copy link

twant commented Oct 18, 2019

In https://github.com/upperlinecode/CS-and-the-City-Curriculum/blob/master/react/props-jsx.md, props are passed by breaking down a much larger object and passing each part of it to a separate prop.

In practice, this is an example of unnecessary decoupling, and does not model best-practices to students. With that in mind, the end challenge, in which the reviews object is passed to a single prop and then broken down within the component constructor needs to be elevated in importance. At a minimum, its visual importance in the markdown file should be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants