-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: credentialStatus support #814
feat: credentialStatus support #814
Conversation
Thank you for the contribution! We had a slightly different idea for how The first reason for this is that there can be multiple status methods ( Also, all the plugin methods that we have so far in this core repository have serializable arguments. This enables us to call these methods over OpenAPI. We don't expect this requirement to hold for all possible plugins but we wish to keep it true for the core plugins. Does this make sense? What do you think? |
Thank you for the detailed explanation. That makes a lot of sense, and I think that approach is more in line with what's already implemented. Have you already started working on the feature? If yes, I would join the discussion/implementation :) |
Fantastic! Some time ago we started this line of work in the form of a library that can orchestrate these implementations: credential-status. The next step there is to redefine the interface expected from a specific We greatly appreciate contributions, so you are welcome to jump in. |
See uport-project/credential-status#39 for some progress on the credential format support |
@tsabolov do you know of any implementations of |
Sorry @mirceanis, somehow missed your message. Need to review my GitHub notifications settings. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
In order to support credential status checks a
checkStatus
function must be passed to vc.js's methodverifyCredential
. A signature ofverifyCredentialLD
method was changed to support the alternative call withcheckStatus
member.