Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packDidCommMessage with did:key recipient fails #681

Closed
mirceanis opened this issue Aug 26, 2021 · 0 comments · Fixed by #682
Closed

packDidCommMessage with did:key recipient fails #681

mirceanis opened this issue Aug 26, 2021 · 0 comments · Fixed by #682
Assignees
@mirceanis
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

Bug severity
3

Describe the bug
packDidCommMessage fails at the DID resolution step because did:key resolver does not include didResolutionMetadata in the result.

To Reproduce
This is noticeable when using the @veramo/cli:
veramo execute -m packDIDCommMessage -a '{"packing":"anoncrypt","message":{"to":"did:key:z6MktEQbgrewCxg3bXkdKAqHJXSEMJVcxUhcEvkWVqyBpzYn", "body":{"hello":"world"}}}'

Observed behaviour
This fails with TypeError: Cannot read property 'error' of undefined

Versions:

  • Veramo: 2.1.1
@mirceanis mirceanis added the bug Something isn't working label Aug 26, 2021
@mirceanis mirceanis self-assigned this Aug 26, 2021
mirceanis added a commit that referenced this issue Aug 26, 2021
@mirceanis
fix(did-resolver): always include didResolutionMetadata in result
35b7852 
fixes #681
@mirceanis mirceanis mentioned this issue Aug 26, 2021
Merged
mirceanis added a commit that referenced this issue Aug 26, 2021
@mirceanis
fix(did-resolver): always include didResolutionMetadata in result (#682)
aabddb4 
fixes #681
@mirceanis mirceanis mentioned this issue Sep 20, 2021
Merged
@pauldesmondparker pauldesmondparker mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(did-resolver): always include didResolutionMetadata in result decentralized-identity/veramo
1 participant
@mirceanis