refactor: Rename Identity to Identifier #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #308 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 62 62
Lines 1504 1504
Branches 237 237
=======================================
Hits 1026 1026
Misses 382 382
Partials 96 96 |
mirceanis
requested changes
Dec 17, 2020
There was a problem hiding this comment.
I think some of the renames make sense but for the others I would either use a different name or not rename at all.
The main reason is that in our case we're not dealing only with identifier strings but with objects with multiple properties, one of which is the identifier (did)
Please take a look at the suggestions.
Also, I think we could use some input from @awoie here as well.
mirceanis
requested changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.