-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segoe UI Symbols/Segoe MDL2 Assets are not properly applied #4579
Comments
This is a duplicate of #4435 as I originally filed it. Note that it may be better to use the resource key for the symbol font in all cases. That means updating the styles in WinUI to stop hard-coding the font I suspect. I'm not sure we want to actually translate the segoe font names to Uno's equivalent. If anyone wanted to use the windows font for whatever reason then it wouldn't work. The 'correct' fix is to use the symbols font resource. |
I would personally still vote for having this supported out of the box so that we are as close to UWP functionality as possible (e.g. when a new dev starts using Uno, we want to make sure there is the least number of gotchas as possible). My suggestion would be to translate |
If it's behind a feature flag that would mitigate my concerns. We would get full compatibility for copy pasted styles or devs that directly use the font name (which they shouldn't). Then if people actually need to use the windows font for whatever reason (the minority of devs for sure) it would still be supported. |
I opened an issue in the WinUI repo. I noticed you already changed this in the TabView XAML but really we should change it in the source and just copy/paste XAML verbatim. |
Note that upstream WinUI just fixed usage of the font name directly. It is now using the symbol font resource instead. Whenever Uno applies the latest styles (likely after the Windows design refresh) this should help for all built-in styles. It's still a good idea of course to translate the font name (enabled by a feature flat). https://github.com/microsoft/microsoft-ui-xaml/pull/3923/files
|
Current behavior
Consider the following:
or the following:
In both cases, an invalid icon is rendered on Android:
This may also occur on other platforms, tested on Android only.
Expected behavior
Should render the proper icon.
How to reproduce it (as minimally and precisely as possible)
See above.
Workaround
Reference the Fluent assets font directly:
Environment
Nuget Package:
Nuget Package Version(s):
Affected platform(s):
The text was updated successfully, but these errors were encountered: