-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uno.Sdk (5.2 templates) only allows ApplicationDisplayVersion value 1.0 #16618
Comments
This is certainly strange. The Uno.Sdk doesn't actually handle this property at all, it's all the underlying Microsoft Sdk's for Android/iOS/MacCatalyst that handle this. |
The error is flagged in VS only, and is reported as follows :
This would indicate that something is changing |
This is likely caused by https://github.com/xamarin/xamarin-android/blob/98c10631d6bd67d6fab70ebab041abb47141daaf/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets#L132, which sets We probably should be setting the same version for all app heads. |
Is there a workaround for this? |
@mikernet yes, you can set the |
@BrianDT @mikernet to get this working you can do the following:
Note that if the |
The end to end support should now be available from the latest 5.3 dev build of the Uno.Templates from the Command Line. If you have any trouble you can take a look at the differences there. Note that the Package.appxmanifest has been cleaned up a lot (see unoplatform/uno.templates#692) and a number of properties/elements have simply been removed. |
Current behavior
If ApplicationDisplayVersion is set to anything other than 1.0 the build will fail to resolve Uno and other references.
Results in
Expected behavior
Should be the same as
How to reproduce it (as minimally and precisely as possible)
Reproduce by creating a new solution and project from the Uno Platform App template and just change the ApplicationDisplayVersion.
Wait for all the dependencies to error and then build.
Workaround
Keep the ApplicationDisplayVersion as 1.0, however this becomes a significant issue when you need to release a new build of an existing product.
Works on UWP/WinUI
None
Environment
No response
NuGet package version(s)
Affected platforms
WebAssembly, Android, iOS, Mac Catalyst, Windows (WinAppSDK)
IDE
Visual Studio 2022
IDE version
17.9.6
Relevant plugins
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: