Animation not picking up the current set/animated value

[eriklimakc]

Current behavior

This happens in all platforms except Windows.

Apparently when the animation code is executed, the Text, Header, and Placeholder are quickly set to their default state and after that they are animated.

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

Checkout this branch on Uno.Themes and launch on non-windows platform.

For the FilledTextBoxStyle the animation is defined in: TextBox.xaml#L420.

Workaround

In order to test I replaced the animation for Setters like below and we don't have that behavior.

<Setter Target="HeaderElement_CompositeTransform.TranslateY"
	Value="-11" />
<Setter Target="ContentElement_CompositeTransform.TranslateY"
	Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource EmptyToFocusedContentCompositeTransformTranslateY}, TargetNullValue=0, FallbackValue=0}" />
<Setter Target="PlaceholderElement_CompositeTransform.TranslateY"
	Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource EmptyToFocusedContentCompositeTransformTranslateY}, TargetNullValue=0, FallbackValue=0}" />
<Setter Target="HeaderElement_CompositeTransform.ScaleX"
	Value="0.7" />
<Setter Target="HeaderElement_CompositeTransform.ScaleY"
	Value="0.7" />

Environment

Works on UWP/WinUI: YES
NuGet package version(s): [email protected]
Affected platforms: This happens in all platforms except Windows.

Anything else we need to know?

Comment left by @Xiaoy312:

"At a glance, this seems like an issue with the animation not picking up the current set/animated value as the starting point for the (start...end) animation. This is not probably not something we will fix here, but in uno."

[agneszitte]

cc @MartinZikmund / @dr1rrb / @Xiaoy312

[agneszitte]

@jeromelaban / @MartinZikmund this issue is kind of blocking @eriklimakc's PR here unoplatform/Uno.Themes#1014
(cc @kazo0, @Xiaoy312)

[kazo0]

Since this will cause a regression in the animation for all Uno platforms, I'd say it's definitely blocking us from merging unoplatform/Uno.Themes#1014

[kazo0]

@dr1rrb does this happen to look familiar at all? Currently blocking this unoplatform/Uno.Themes#974

[dr1rrb]

No nothing familiar here, sorry :(

[kazo0]

@Youssef1313 is it possible this will be fixed/related to any of the animation stuff you are doing recently?

[Youssef1313]

I don't think what I have will fix it.

[Xiaoy312]

looks like a regression from #11859 ?

[agneszitte]

@eriklimakc I imagine this is still happening with latest versions?

[eriklimakc]

Apparently fixed on latest Uno packages. Quickly tested all platforms and didn't see the issue anymore. You can also see on the stage site: https://salmon-rock-0cfebe70f-1014.eastus2.azurestaticapps.net/ from unoplatform/Uno.Themes#1014.

Will do more deep tests and update here on the issue.

cc @Xiaoy312 @agneszitte @kazo0

[Xiaoy312]

unassigned me and close this, if your deep tests are positive.

[eriklimakc]

Closing as not reproducible anymore.

[eriklimakc]

@kazo0 It was fixed on 5.3.0-dev.906.

[Youssef1313]

For reference, that version belongs to #16474

FYI @ramezgerges :)