Task/deterministic serialization #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sighphyre
reviewed
Jan 27, 2023
src/client_features.rs
Outdated
| @@ -82,6 +89,24 @@ where | |||
| })) | |||
| } | |||
|
|
|||
| /// | |||
| /// We need this to ensure that | |||
There was a problem hiding this comment.
I feel like this sentence isn't complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "hashes" feature to this library, it also updates the serialization of maps to use OrderedMaps to make sure the order of keys are deterministic. This was needed to have the hash of the ClientFeatures struct be deterministic