docs: add auth and context #112
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage ? 76.55%
=======================================
Files ? 9
Lines ? 708
Branches ? 146
=======================================
Hits ? 542
Misses ? 164
Partials ? 2 ☔ View full report in Codecov by Sentry. |
docs/1.guide/2.hooks.md
Outdated
|
|
||
| const hooks = defineHooks({ | ||
| upgrade(request) { | ||
| const userAuth = request.headers.get("Authorization"); |
There was a problem hiding this comment.
Maybe use basic auth for better understanding?
One benefit of basic auth is that we can also make a proper response that asks for it.
There was a problem hiding this comment.
Like the full process of checking if userAuth is Basic, then use undio to parse the base64 and then check the user and pass? If auth is missing/incorrect respond with WWW-Authenticate header?
There was a problem hiding this comment.
We can use simple atob/btoa but yes a very simple user:pass auth if possible.
There was a problem hiding this comment.
With this PR I'm learning a few things about responses and WWW-Authenticate, so feel free to roast me 😅
|
Thanks @sandros94, this gave me some much needed guidance! However, I found that setting the context to an object doesn't work, you have to set specific properties. For example (using Trying to set upgrade(request) {
request.context = { data: 'test'}
},
open(peer) {
console.log(peer.context) // logs {}
}Setting a specific property in upgrade(request) {
request.context.data = 'test'
},
open(peer) {
console.log(peer.context) // logs { data: 'test' }
} |
Co-authored-by: Travis Reynolds <[email protected]>
|
@travis-r6s thanks for reporting it! Indeed context is already initialized 😅 |
|
Good point @travis-r6s ~> #115 |
Resolves #88
Should I also add an auth example via cookie?
I might need some help on the
ok: falsebackward compatible thing