From db2bf41537ea3e137eddc1e31e803bb02f7481d1 Mon Sep 17 00:00:00 2001 From: Dustin Brunner Date: Thu, 16 Jun 2022 12:00:14 +0200 Subject: [PATCH 1/2] automatic linting --- darts/logging.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/darts/logging.py b/darts/logging.py index 3f85052861..13cb775735 100644 --- a/darts/logging.py +++ b/darts/logging.py @@ -23,12 +23,16 @@ def get_logger(name): logger = logging.getLogger(name) logger.setLevel(logging.INFO) - stderr_handler = logging.StreamHandler() + handler = ( + logging.StreamHandler() + if os.environ.get("DISABLE_DARTS_LOGGING") != "1" + else logging.NullHandler() + ) formatter = logging.Formatter( "[%(asctime)s] %(levelname)s | %(name)s | %(message)s" ) - stderr_handler.setFormatter(formatter) - logger.addHandler(stderr_handler) + handler.setFormatter(formatter) + logger.addHandler(handler) return logger From ad7a40422e8652c8abcfc879df55d36ec1bd971c Mon Sep 17 00:00:00 2001 From: Dustin Brunner Date: Tue, 21 Jun 2022 15:49:05 +0200 Subject: [PATCH 2/2] don't add custom handlers and formatter to loggers --- darts/logging.py | 12 ++---------- darts/models/__init__.py | 8 ++++---- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/darts/logging.py b/darts/logging.py index 13cb775735..54ba06148c 100644 --- a/darts/logging.py +++ b/darts/logging.py @@ -22,17 +22,9 @@ def get_logger(name): """ logger = logging.getLogger(name) + # default logging level is logging.INFO logger.setLevel(logging.INFO) - handler = ( - logging.StreamHandler() - if os.environ.get("DISABLE_DARTS_LOGGING") != "1" - else logging.NullHandler() - ) - formatter = logging.Formatter( - "[%(asctime)s] %(levelname)s | %(name)s | %(message)s" - ) - handler.setFormatter(formatter) - logger.addHandler(handler) + return logger diff --git a/darts/models/__init__.py b/darts/models/__init__.py index 387602e4f5..1409ecb5f5 100644 --- a/darts/models/__init__.py +++ b/darts/models/__init__.py @@ -26,7 +26,7 @@ from darts.models.forecasting.auto_arima import AutoARIMA from darts.models.forecasting.tbats import BATS, TBATS except ModuleNotFoundError: - logger.warning( + logger.info( "Support for AutoARIMA, BATS and TBATS is not available." "To enable it, install u8darts[pmdarima] or u8darts[all]." ) @@ -34,7 +34,7 @@ try: from darts.models.forecasting.prophet_model import Prophet except ModuleNotFoundError: - logger.warning( + logger.info( "Support for Facebook Prophet is not available. " 'To enable it, install "darts", "u8darts[prophet]" or "u8darts[all]" (with pip);' 'or "u8darts-all" (with conda).' @@ -50,7 +50,7 @@ from darts.models.forecasting.transformer_model import TransformerModel except ModuleNotFoundError: - logger.warning( + logger.info( "Support for Torch based models not available. " 'To enable them, install "darts", "u8darts[torch]" or "u8darts[all]" (with pip); ' 'or "u8darts-torch" or "u8darts-all" (with conda).' @@ -59,7 +59,7 @@ try: from darts.models.forecasting.gradient_boosted_model import LightGBMModel except ModuleNotFoundError: - logger.warning( + logger.info( "Support for LightGBM not available." "To enable LightGBM support in Darts, follow the detailed " "install instructions for LightGBM in the README: "