Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Consistent model naming #947

Closed
gdevos010 opened this issue May 4, 2022 · 0 comments · Fixed by #1000
Closed

[BUG] Consistent model naming #947

gdevos010 opened this issue May 4, 2022 · 0 comments · Fixed by #1000
Labels
bug Something isn't working triage Issue waiting for triaging

Comments

@gdevos010
Copy link
Contributor

Describe the bug
NHiTS class should be renamed to NHiTSModel to match naming convention of all other models.

(

class NHiTS(PastCovariatesTorchModel):
def __init__(
self,
input_chunk_length: int,
output_chunk_length: int,
num_stacks: int = 3,
num_blocks: int = 1,
num_layers: int = 2,
layer_widths: Union[int, List[int]] = 512,
pooling_kernel_sizes: Optional[Tuple[Tuple[int]]] = None,
n_freq_downsample: Optional[Tuple[Tuple[int]]] = None,
dropout: float = 0.0,
**kwargs,
):
)

@gdevos010 gdevos010 added bug Something isn't working triage Issue waiting for triaging labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue waiting for triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant