Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tensorboard does not work with gridsearch when model_name is provided #759

Closed
gdevos010 opened this issue Jan 27, 2022 · 1 comment · Fixed by #760
Closed

[BUG] tensorboard does not work with gridsearch when model_name is provided #759

gdevos010 opened this issue Jan 27, 2022 · 1 comment · Fixed by #760
Labels
bug Something isn't working triage Issue waiting for triaging

Comments

@gdevos010
Copy link
Contributor

Describe the bug
providing a model name when using gridsearch puts all files under the same folder ./darts/runs/MODEL_NAME
this breaks tensorboard

To Reproduce

NBEATS_params = {
        "log_tensorboard": [True],
        "model_name": ["NBEATS_gs"],
        "layer_widths": [256, 512, 1024],
}

best_model, dict_params = NBEATSModel.gridsearch(NBEATS_params, train_air, val_series=val_air, metric=mape, n_jobs=3, verbose=True)

Expected behavior
each run should have its own dir

System (please complete the following information):

  • Python version: 3.7
  • darts version 0.16.0

Additional context

@gdevos010 gdevos010 added bug Something isn't working triage Issue waiting for triaging labels Jan 27, 2022
@hrzn
Copy link
Contributor

hrzn commented Jan 27, 2022

Thanks for flagging. Indeed currently gridsearch was not really meant to work with Tensorboard. Anyway we have a bit of refactoring to do around gridsearch. Leaving this one open for the time being.

@gdevos010 gdevos010 changed the title [BUG] [BUG] tensorboard does not work with gridsearch when model_name is provided Jan 28, 2022
@hrzn hrzn closed this as completed in #760 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue waiting for triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants