Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float seasonal_periods in Prophet #1828

Closed
gregorp90 opened this issue Jun 14, 2023 · 1 comment
Closed

Support float seasonal_periods in Prophet #1828

gregorp90 opened this issue Jun 14, 2023 · 1 comment
Labels
improvement New feature or improvement

Comments

@gregorp90
Copy link

Is your feature request related to a current problem? Please describe.
I would like to add a custom seasonality to the Prophet model. For example, weekly data with yearly seasonality. This set up requires 52.18 periods. But Darts requires the seasonal_periods to be an integer and raises an exception if a float is provided, while base Prophet allows floats.

At the moment we can only use 52, which will shift the seasonality if we are forecasting over a longer period, which is wrong.

Describe proposed solution
Change the seasonality_properties dictionary in _store_add_seasonality_call in the Prophet model so that seasonal_periods can be a float.

@gregorp90 gregorp90 added the triage Issue waiting for triaging label Jun 14, 2023
@madtoinou madtoinou added improvement New feature or improvement and removed triage Issue waiting for triaging labels Jun 14, 2023
@madtoinou
Copy link
Collaborator

Fixed by #1829.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants