-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Scalers applied on multiple series #1288
Comments
Ok after some reading I think this might be intent behavior. If so I have a question / Suggestion: As I understand it now, if multiple This makes it not possible to run the FittableDataTransformer if only one And please as a hot-fix add a warning if the length of the sequence of Series to |
Hi @maximilianreimer, thanks for writing. You are totally right. Our data transformers expect to receive the same input dimensions (and same order of list of time series including their components) for fitting and transformation. We should definitely raise a warning (or even an exception?) if there is a mismatch in dimensions. I don't quite follow what the issue is with using transformers in production? Can't you fit transform a new transformer only on the series available? Regarding "sub-FittableDataTransformer":
|
Regarding the production issue: Lets say I have n areas I want to forecast electricity prices for. On training time I have a sequence of time series of the prices I pass through my target pipeline and model but in production I might have the request to just predict a specific time series. Model-wise that's not a problem, but how to use the Scaler in this instance?
|
Do you have all historical data for the specific series at prediction time? If so, then you can fit/transform with a new scaler just on this single series as you did before training. |
So you are suggesting to train different Scaler for each Series? Or one joint for training and afterwards individual ones for prediction time? |
One joint Scaler for training (which should come with a performance boost compared to multiple single Scalers) and afterwards an individual one.
|
What approach would you recommend if we don't have the complete historical data (e.g., only the necessary data for |
+1 for raising an exception if the number doesn't match, that's a good point. |
This is solved by #1409, which implements a mappable to match the |
Describe the bug
If a
Scaler
is fitted onn_fitted
sequences at once. It will always only returnsn_fitted
Sequences but not the number of inputted sequences.To Reproduce
Expected behavior
Should scale all series independently and return the same number as inputed.
System (please complete the following information):
The text was updated successfully, but these errors were encountered: