Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Update 08-wasm client when it is merged into main #674

Closed
aeryz opened this issue Sep 11, 2023 · 1 comment
Closed

[Tracking] Update 08-wasm client when it is merged into main #674

aeryz opened this issue Sep 11, 2023 · 1 comment
Assignees

Comments

@aeryz
Copy link
Contributor

aeryz commented Sep 11, 2023

08-wasm client is still being developed under feat/wasm-clients branch of ibc-go and it's still changing frequently. This issue will track the issues/PR's and note the changes so that we don't have hard time when we update.

Here are the PRs/issues that propose changes in the public API, or have notable changes that are good to know:

  1. Return error before trying to initialize the contract by storing the code hash: Only store code hashes in store. cosmos/ibc-go#4292

Changes that are already been implemented:

  1. CodeId field in the ClientState is changed to CodeHash.
  2. Code field in MsgStoreCode is changed to WasmByteCode
  3. As this spec change says: ICS8: Update the WASM Client spec cosmos/ibc#901, the read-only calls are changed to be queries, and write calls are changed to sudo calls.
@aeryz aeryz self-assigned this Sep 11, 2023
@aeryz aeryz changed the title Update 08-wasm client when it is merged into main [Tracking Issue] Update 08-wasm client when it is merged into main Oct 24, 2023
@aeryz aeryz pinned this issue Oct 24, 2023
@cor cor changed the title [Tracking Issue] Update 08-wasm client when it is merged into main [Tracking] Update 08-wasm client when it is merged into main Nov 27, 2023
@aeryz
Copy link
Contributor Author

aeryz commented Nov 28, 2023

Closing in favor of #974

@aeryz aeryz closed this as completed Nov 28, 2023
@aeryz aeryz unpinned this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant