Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer sizes of day_of_year, day_of_month #4896

Closed
sffc opened this issue May 13, 2024 · 1 comment · Fixed by #5702
Closed

Integer sizes of day_of_year, day_of_month #4896

sffc opened this issue May 13, 2024 · 1 comment · Fixed by #5702
Labels
2.0-breaking Changes that are breaking API changes C-calendar Component: Calendars
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented May 13, 2024

day_of_year is a u16 but day_of_month is as u32.

Worth fixing?

@Manishearth @echeran
@sffc sffc added needs-approval One or more stakeholders need to approve proposal C-calendar Component: Calendars 2.0-breaking Changes that are breaking API changes labels May 13, 2024
@sffc sffc added this to the ICU4X 2.0 milestone May 13, 2024
@sffc sffc added this to icu4x 2.0 May 13, 2024
@sffc sffc moved this to Needs discussion to unblock in icu4x 2.0 May 13, 2024
@Manishearth
Copy link
Member

Probably, yes.

@sffc sffc moved this from Needs discussion to unblock to Small breakage (defer to end) in icu4x 2.0 May 21, 2024
@sffc sffc removed the needs-approval One or more stakeholders need to approve proposal label May 21, 2024
@Manishearth Manishearth mentioned this issue Oct 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from Small breakage (defer to end) to Done in icu4x 2.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0-breaking Changes that are breaking API changes C-calendar Component: Calendars
Projects
icu4x 2.0
Status: Done
Milestone
ICU4X 2.0 ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

Shorten integer type of day_of_month, week_of_month, week_of_year Manishearth/icu4x
2 participants
@sffc @Manishearth