You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a policy of strongly preferring Options structs to be Copy. But the new Datagen Options contain some HashSets. Should they instead be borrowing those fields?
The text was updated successfully, but these errors were encountered:
@Manishearth - Datagen is its own thing. When we decided the policy of Copy I was mostly thinking about components. That's not to say that we shouldn't make this Copy, but I feel it's out of scope of the general policy.
@Manishearth - The component styles were designed for reasons specifically about components. But we can look at these two reasons. For re-use of the options, it's not clear if that's compelling for Datagen. For default-spread, that seems valid. It's not super conventional for options structs to get lifetimes. I'm not opposed to making it Copy, but I'm not convinced we must.
@robertbastian - This might not need to be an options bag. Where does the export method live? It could become a free function. It could also be a method on the options bag.
@sffc - I do think we should move in the direction of a DataExporter that owns these options and then plumbs a DataProvider to a DataConsumer. And that decision changes whether or not we borrow the options.
Decision: Table this discussion until #3564 is resolved.
We have a policy of strongly preferring Options structs to be Copy. But the new Datagen Options contain some HashSets. Should they instead be borrowing those fields?
The text was updated successfully, but these errors were encountered: