Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify benchmark names #324

Closed
zbraniecki opened this issue Oct 10, 2020 · 0 comments · Fixed by #325
Closed

Unify benchmark names #324

zbraniecki opened this issue Oct 10, 2020 · 0 comments · Fixed by #325
Assignees
Labels
C-test-infra Component: Integration test infrastructure T-enhancement Type: Nice-to-have but not required
Milestone

Comments

@zbraniecki
Copy link
Member

Now that we did more work around Plurals benchmarks I have a framework to work with documented here: https://github.com/unicode-org/icu4x/wiki/Benchmarking

I'd like to take all benchmarks and separate overview from detailed benchmarks for 0.1, even if we don't separate ones run by default from ones behind bench feature.

The goal is so that when you run cargo bench overview you get only a subset of benchmarks that are giving a high level overview and this is what we'll use in CI.

@zbraniecki zbraniecki added this to the ICU4X 0.1 milestone Oct 10, 2020
@zbraniecki zbraniecki self-assigned this Oct 10, 2020
@sffc sffc added C-test-infra Component: Integration test infrastructure T-enhancement Type: Nice-to-have but not required labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-infra Component: Integration test infrastructure T-enhancement Type: Nice-to-have but not required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants