Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Ungoogled Chromium include FLoC code? #1474

Closed
ceodoe opened this issue Apr 8, 2021 · 12 comments · Fixed by #1536
Closed

Does Ungoogled Chromium include FLoC code? #1474

ceodoe opened this issue Apr 8, 2021 · 12 comments · Fixed by #1536

Comments

@ceodoe
Copy link

ceodoe commented Apr 8, 2021

Is the current FLoC origin trial included in Ungoogled Chromium? How will it be handled once trials are over and it's fully implemented and ready to go in Chromium? Sources mention the code for this trial made it into Chromium (and not just Chrome), and thus I would assume it would propagate downstream to this project. I searched the internet and this issue tracker, but found no mention of Ungoogled's stance on this controversial inclusion in Chromium.

https://www.eff.org/deeplinks/2021/03/google-testing-its-controversial-new-ad-targeting-tech-millions-browsers-heres

https://source.chromium.org/chromium/chromium/src/+/master:components/federated_learning/?q=federated%20learning&ss=chromium%2Fchromium%2Fsrc

WICG/floc#25

@Ahrotahn
Copy link
Contributor

Ahrotahn commented Apr 8, 2021

The code exists, but field trials should not be active unless your version of chromium was built with fieldtrial_testing_like_official_build=is_chrome_branded. Most builds should be made with fieldtrial_testing_like_official_build=true, which oddly enough disables the field trials (More info here and here).

It also seems to (in it's current implementation) check https://adservice.google.com/settings/do_ad_settings_allow_floc_poc for permission to start the trial, so even if the field trials are somehow enabled ungoogled-chromium's domain substitution would prevent that from going through.

It might be a bit too early to implement a patch right now to remove this since there will likely be a lot of changes to this code in the upcoming releases, but it wouldn't be too difficult to implement a patch before it becomes enabled by default.


Extra info:

That EFF article only links the component part to floc, the rest is here

There is a Google blog post here that goes into more detail about the trial.

@notDavid
Copy link

FYI: brave/brave-core#8468 (https://news.ycombinator.com/item?id=26765084)

@dm17
Copy link

dm17 commented Apr 13, 2021

Has this been confirmed?
https://vivaldi.com/blog/no-google-vivaldi-users-will-not-get-floced/ Vivaldi doesn't btw.

@alexolog
Copy link

Just wanted to add my vote for either removing or disabling this "feature"

@Peacock365
Copy link

@Eloston

Seems like Vanadium has patched FLoC, the fix seems applicable to Ungoogled Chromium:

https://github.com/GrapheneOS/Vanadium/blob/11/patches/0078-disable-unused-FLOC-feature.patch

Can we please have the same fix in Ungoogled Chromium?

@dm17
Copy link

dm17 commented May 1, 2021

@Eloston

Seems like Vanadium has patched FLoC, the fix seems applicable to Ungoogled Chromium:

https://github.com/GrapheneOS/Vanadium/blob/11/patches/0078-disable-unused-FLOC-feature.patch

Can we please have the same fix in Ungoogled Chromium?

Are you tracking differences between UG & Vanadium? I'm curious about that too - and wonder if the projects can help deduplicate each others efforts.

@ghost
Copy link

ghost commented May 13, 2021

According to https://amifloced.org/ last ungoogled chromium (89.0.4389.114) does not have FLoC enabled:

image

@Altonss
Copy link

Altonss commented May 13, 2021

That may be normal, because I think that all Chrome Users don't have Floc enabled either.

@mdedonno1337
Copy link

What is the current situtation and plan for the FLOC removal?
Should we simply "import" the migitation proposed by other projects?

@Ahrotahn
Copy link
Contributor

Ahrotahn commented Jun 4, 2021

I've had a patch ready for a while that disables the current implementation, but I've been waiting to see what changes get made before mid-July. So far it hasn't had as much activity as I thought it would have. I'll take some time this weekend to update the patch a bit and submit a PR afterwards.

@Peacock365
Copy link

@Ahrotahn

Thank you again for the patch. It seems like the Bromite project has failed to implement your patch, they seem to rely entirely on Google's preset conditions for FLoC being enabled. They see no necessity to explicitly patch this, and when I hinted at your patch in frustration, my comment got marked as "disruptive content" (well yes, that is correct, it is meant to "disrupt" the developer's lazy development attitude). If you can, please comment on why a patch is necessary in my stead:

bromite/bromite#1104

You don't have to, but seeing how you are the author of an applicable patch and since I would like to continue using Bromite on mobile, could you please help me out there in the interest of all Bromite users? Thank you.

@dm17
Copy link

dm17 commented Jun 28, 2021

@Peacock365 You might be interested in this effort: #1395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants