Test handle method returns false on invalid resolutions

unclexo · Jan 28, 2023 · ace2fc6 · ace2fc6
1 parent 3a99822
commit ace2fc6
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/app/Jobs/ImageUploadAndResizingJob.php b/app/Jobs/ImageUploadAndResizingJob.php
@@ -57,7 +57,7 @@ public function storage()
      */
     public function handle()
     {
-        if (! $this->isValidImage())
+        if (! $this->isFilteredResolutions() || ! $this->isValidImage())
             return false;
 
         $path = sprintf(
@@ -82,6 +82,17 @@ public function handle()
         return $paths;
     }
 
+    private function isFilteredResolutions()
+    {
+        return array_filter((array) $this->resolutions, function ($value, $key) {
+            return is_array($value) &&
+                count($value) === 2 &&
+                is_string($key) &&
+                $value[0] > 0 &&
+                $value[1] > 0;
+        }, ARRAY_FILTER_USE_BOTH);
+    }
+
     private function isValidImage()
     {
         if (

diff --git a/tests/Feature/JobTest.php b/tests/Feature/JobTest.php
@@ -102,4 +102,27 @@ public function handle_method_returns_false_on_invalid_image_content()
 
         $this->assertFalse($job->handle());
     }
+
+    /** @test */
+    public function handle_method_returns_false_on_invalid_resolutions()
+    {
+        Storage::fake('public');
+
+        $image = UploadedFile::fake()
+            ->image('image.jpg', 50, 50)
+            ->mimeType('image/jpeg');
+
+        $job = new ImageUploadAndResizingJob($image->getMimeType(), base64_encode($image->getContent()));
+
+        $job->resolutions = [];
+
+        $this->assertFalse($job->handle());
+
+        $job->resolutions = [
+            '50x50' => [-50, 50], // Note the negative number
+            '640x480' => [640], // Note the height is not provided
+        ];
+
+        $this->assertFalse($job->handle());
+    }
 }