Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscribe methods to get params on backend by request body #651

Closed
akellbl4 opened this issue Apr 8, 2020 · 2 comments
Closed

Update subscribe methods to get params on backend by request body #651

akellbl4 opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels

Comments

@akellbl4
Copy link
Collaborator

akellbl4 commented Apr 8, 2020

Now we have methods like /email/subscribe, /email/confirm and these API methods implemented as POST and PUT. But now they are getting parameters from query string.

I think they should get params from request body because it is usual way to pass data over POST/PUT requests. Also, it will be good to send an email/token as is without URL encoding.

@paskal
Copy link
Collaborator

paskal commented Jan 8, 2023

@akellbl4, the change is merged. Feel free to change the frontend calls to utilise the body. tkn became token in the body, and everything else stayed the same.

@paskal paskal removed the backend label Jan 8, 2023
@paskal
Copy link
Collaborator

paskal commented Jun 12, 2023

@Jaskon this one already has backend support as well, feel free to pick it up if you'll have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants