Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anonymous voting #473

Closed
umputun opened this issue Nov 6, 2019 · 1 comment · Fixed by #541
Closed

Allow anonymous voting #473

umputun opened this issue Nov 6, 2019 · 1 comment · Fixed by #541
Assignees
@akellbl4
Labels
enhancement frontend
Milestone
v1.5

Comments

@umputun
Copy link
Owner

umputun commented Nov 6, 2019

Currently, anonymous users can't vote. This is not a bug but expected behavior as we had no way to prevent abuse in such a case. However, with #400 in place, we may allow it.

This is going to be a new param (disabled by default) and in case of votes IP check disabled, will show a warning in logs.

triggered by #472
@umputun umputun added this to the v1.5 milestone Nov 6, 2019
@umputun umputun mentioned this issue Nov 6, 2019
Closed
@paskal paskal mentioned this issue Dec 26, 2019
Merged
@paskal
Copy link
Collaborator

paskal commented Dec 26, 2019

Now there is an anon_vote option in /config endpoint and in case it's true, an anonymous user is allowed to vote.
What is missing is frontend support for it: currently, the anonymous user is always restricted from voting.

@akellbl4 akellbl4 self-assigned this Jan 7, 2020
@akellbl4 akellbl4 mentioned this issue Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akellbl4 akellbl4

Labels
enhancement frontend
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Allow voting for anonymous users akellbl4/remark42
3 participants
@umputun @paskal @akellbl4