Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few frontend improvement ideas #426

Closed
leem32 opened this issue Aug 26, 2019 · 8 comments
Closed

A few frontend improvement ideas #426

leem32 opened this issue Aug 26, 2019 · 8 comments

Comments

@leem32
Copy link

leem32 commented Aug 26, 2019

I know there's no ETA for any frontend refactoring, but just wanted to add a few ideas for what in my opinion would improve remark42.

Show the comments box even if a user is not logged in.
Or at least add an option for this in the config parameters.
I believe this would greatly increase the chances of a user posting a comment.
The user could type their comment and when they click the submit button a popup would appear saying "Please login to comment".

Reduce the length of the sign in to comment line.
This line of text is too long IMO and looks messy for smaller viewports and if you need to place your comments in a narrow container.
Instead of: "Sign in to comment using Google, Yandex, Facebook or email" you could just have "Login: " followed by the social login/email icons similar to the way Disqus does.

Also the dropdown boxes for email login and username break outside the container at certain viewports or in narrow containers which also looks messy and obviously unreadable.

Those are the 3 things I would most like to see added/fixed in remark42.

Thanks :)

@umputun
Copy link
Owner

umputun commented Aug 26, 2019

Show the comments box even if a user is not logged in.

Not a bad idea. Probably such "always-on" can be an option, non-default

Reduce the length of the sign in to comment line.

Agree

Also the dropdown boxes for email login and username

This is a bug, and yeah - should be fixed

@Reeywhaar - for the first one, I can add a flag exposed to /config. Hopefully doing it not a big deal on your side. For others - all yours

@akellbl4
Copy link
Collaborator

akellbl4 commented Jan 5, 2020

Show the comments box even if a user is not logged in.

I think it is not small feature. I will think about it later.

Reduce the length of the sign in to comment line.

@umputun can I change "Sign in to comment using ..." to "Login: ..." or "Login via ..."?

Also the dropdown boxes for email login and username break outside the container at certain viewports or in narrow containers which also looks messy and obviously unreadable.

@leem32 can you provide some screenshots or viewport sizes?

@umputun
Copy link
Owner

umputun commented Jan 5, 2020

can I change "Sign in to comment using ..." to "Login: ..." or "Login via ..."?

sure, good idea

@leem32
Copy link
Author

leem32 commented Jan 5, 2020

Oddly I can't seem to reproduce the issue I was having with the username dropdown box.
I do notice, when I log into comments the sort by options box escapes its container which can cause the right side of the sort by options box to be cut off for narrow mobile viewports in a 1 column layout with no gutter.

(Screenshots using Chrome Dev tools mobile view.)
These screenshots show when a user is logged in the sort-by options box expands further to the right than when a user is not logged in.

User not logged in: (this is fine)
remark42 not logged in

User logged in.
remark42 logged in

@akellbl4
Copy link
Collaborator

akellbl4 commented Jan 5, 2020

@leem32 it's not a problem :) This is the default browser select (not HTML markup). It can render differently in different browsers. On a mobile device, it looks completely different.

For example on iOS

IMG_29170CCAF844-1

@leem32
Copy link
Author

leem32 commented Jan 5, 2020

Good point, prob not an issue then. I'll let you know if I come across the username dropdown box issue I mentioned in the op :)

@akellbl4
Copy link
Collaborator

akellbl4 commented Jan 6, 2020

@leem32 thanks ;)

@paskal
Copy link
Collaborator

paskal commented Jan 8, 2023

I see that the issues mentioned here are fixed, resolving this issue. Feel free to comment if I'm wrong.

@paskal paskal closed this as completed Jan 8, 2023
@paskal paskal added this to the v1.6 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants