Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Terratest #5

Merged
merged 10 commits into from
Dec 15, 2020
Merged

Introduce Terratest #5

merged 10 commits into from
Dec 15, 2020

Conversation

Ohid25
Copy link
Contributor

@Ohid25 Ohid25 commented Dec 9, 2020

Description

  1. Refactor KMS module to use data block for policy
  2. Refactor VPC and subnets to use default vpc
  3. Variablise naming of each resource
  4. Add an initial set of tests for Vault

Introduce Terratest
fa00a6a 
1. Refactor KMS module to use `data` block for policy
2. Refactor VPC and subnets to use default vpc
3. Variablise naming of each resource
4. Add initial set of tests for Vault
@Ohid25 Ohid25 requested a review from marcincuber December 9, 2020 11:37
@Ohid25 Ohid25 requested a review from marcincuber December 9, 2020 15:55
marcincuber
marcincuber reviewed Dec 15, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
marcincuber
marcincuber approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@marcincuber marcincuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marcincuber marcincuber merged commit 3e4a48f into master Dec 15, 2020
@marcincuber marcincuber deleted the feature/add-terratest branch December 15, 2020 15:54
@Ohid25
Copy link
Contributor Author

Ohid25 commented Dec 15, 2020

https://github.com/umotif-public/terraform-aws-backup/releases/tag/1.2.0

@Ohid25 Ohid25 mentioned this pull request Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcincuber marcincuber marcincuber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ohid25 @marcincuber