-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter and code formatter #88
Comments
Ok, I got Atom's YAPF plugin working, and was surprised to see all the lines wrapped to 80 characters. For some reason I thought PEP8 was 120 character-line compliant, since PyCharm defaults to this line wrap length when running their default reformatter. It turns out PyCharm does not enforce PEP8 line length by default though. Unfortunately I wrote the whole repo with 120 character lines in mind, so the YAPF reformat really destroys much of the carefully crafted code I had written over the last year. If YAPF is really industry standard then logically I should adopt it as well for maximal readability and commonality. Perhaps there is some manual reformatting I can do to reduce the impact of the change prior to the switchover. |
Thanks with comments. pycharm settings for example yapf(google) vs yapf(facebook) vs black |
@Ttayu thanks for the suggestions and resources. I appreciate the insight into different formatting options. I'll consider your recommendations and evaluate the best fit for the project. It's important to maintain code readability whilst adhering to industry standards, and your input is valuable for this decision-making process. |
Hi, thanks for sharing your code.
Why not use linter and formatter for keeping code format?
I think it is just personal preference on which configuration to take or which formatter to choose.
For example, as a formatter I recommend yapf.
Please by all means take advantage :)
The text was updated successfully, but these errors were encountered: