Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate layout with cise stuck #323

Closed
canbax opened this issue Dec 22, 2020 · 9 comments
Closed

Recalculate layout with cise stuck #323

canbax opened this issue Dec 22, 2020 · 9 comments

Comments

@canbax
Copy link
Collaborator

canbax commented Dec 22, 2020

  • Load sample data
  • Group by Louvain algorithm in circular mode
  • Show all persons of "Ziegfeld Follies"
  • Recalculate layout

It sticks there. There might be somehow an infinite computation or memory leak.

Another problem might be after you "show all persons" for a movie, disconnected components might be far away from each other.

  • Here is a snippet from performance tests -
    image

The image shows the packComponents method of https://github.com/iVis-at-Bilkent/cytoscape.js-layout-utilities takes nearly 363 seconds. Inside this function, getDirectNeighbors takes nearly 301 seconds. I observed that if I make incremental layout, it only takes 1-2 seconds.

Below is the graph we try to recalculate layout and its data exported as JSON.

visuall (3)
cise-bug.txt

An issue is generated in layout-utilities extension iVis-at-Bilkent/cytoscape.js-layout-utilities#22

@canbax canbax assigned canbax and ugurdogrusoz and unassigned canbax Dec 22, 2020
@ugurdogrusoz ugurdogrusoz removed their assignment Feb 3, 2021
@ugurdogrusoz
Copy link
Owner

ugurdogrusoz commented Jun 15, 2021

@canbax Can we update Visuall to be using the latest of CiSE unstable branch, so I can evaluate this?

@canbax
Copy link
Collaborator Author

canbax commented Jun 16, 2021

Since we deleted the package-lock.json file from Github, Heroku deployment will always use the latest version after a build. So Visuall should use the latest version after a build.

I see that recalculate layout doesn't stick but still, it takes some time around 2 seconds. It freezes the browser. You can see that in the below image

image

Also, the second issue seems still exists. When I show all persons of "Ziegfeld Follies", the resulting layout is very very small. You can see that in the below image.
image

Below I put my layout options as text file for the record.
cise-layout-options.txt

@canbax canbax assigned ugurdogrusoz and unassigned canbax Jun 16, 2021
@ugurdogrusoz
Copy link
Owner

ugurdogrusoz commented Jun 17, 2021

CiSE is a slower layout in general.
@canbax Please tell us how to reproduce the second issue (highly separated components in layout)

@canbax
Copy link
Collaborator Author

canbax commented Jun 18, 2021

If you follow

  • Load sample data
  • Group by Louvain algorithm in circular mode
  • Show all persons of "Ziegfeld Follies"
    It should make an incremental layout using cise. This incremental layout gives highly separated components issue.

@ugurdogrusoz
Copy link
Owner

I think the latter is related with this.

@ugurdogrusoz ugurdogrusoz assigned ugurdogrusoz and unassigned canbax Jun 18, 2021
@ugurdogrusoz
Copy link
Owner

ugurdogrusoz commented Jun 23, 2021

Nope, separate component issue is not the same one as this, which was fixed.

@hasanbalci
Copy link
Collaborator

I expect the separate component issue to be resolved with the fix on iVis-at-Bilkent/cytoscape.js-cise#33.

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned hasanbalci Oct 20, 2021
@ugurdogrusoz
Copy link
Owner

@canbax Please check if this is fixed and close if OK

@canbax
Copy link
Collaborator Author

canbax commented Oct 21, 2021

I observed separate component issue is resolved. It gives a better layout. (see below image)
image

But it freezes the browser for 3 seconds. Since

CiSE is a slower layout in general.

I close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants