-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recalculate layout with cise stuck #323
Comments
@canbax Can we update Visuall to be using the latest of CiSE unstable branch, so I can evaluate this? |
Since we deleted the package-lock.json file from Github, Heroku deployment will always use the latest version after a build. So Visuall should use the latest version after a build. I see that recalculate layout doesn't stick but still, it takes some time around 2 seconds. It freezes the browser. You can see that in the below image Also, the second issue seems still exists. When I show all persons of "Ziegfeld Follies", the resulting layout is very very small. You can see that in the below image. Below I put my layout options as text file for the record. |
CiSE is a slower layout in general. |
If you follow
|
I think the latter is related with this. |
Nope, separate component issue is not the same one as this, which was fixed. |
I expect the separate component issue to be resolved with the fix on iVis-at-Bilkent/cytoscape.js-cise#33. |
@canbax Please check if this is fixed and close if OK |
It sticks there. There might be somehow an infinite computation or memory leak.
Another problem might be after you "show all persons" for a movie, disconnected components might be far away from each other.
The image shows the
packComponents
method of https://github.com/iVis-at-Bilkent/cytoscape.js-layout-utilities takes nearly 363 seconds. Inside this function,getDirectNeighbors
takes nearly 301 seconds. I observed that if I make incremental layout, it only takes 1-2 seconds.Below is the graph we try to recalculate layout and its data exported as JSON.
cise-bug.txt
An issue is generated in layout-utilities extension iVis-at-Bilkent/cytoscape.js-layout-utilities#22
The text was updated successfully, but these errors were encountered: