-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a WAM regression test with the MULTI_GASES and MOLECULAR_DIFFUSION options on #714
Add a WAM regression test with the MULTI_GASES and MOLECULAR_DIFFUSION options on #714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR look ok, but I don't understand how the code is supposed to work in fv3atm (and ccpp-physics). Can you please clarify? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes here look good. fv3 PR may need to be updated
Correct the typo.
Automated RT Failure Notification |
Automated RT Failure Notification |
Seems like a PBS issue on Cheyenne:
+ set +x
Connection refused
qsub: cannot connect to server chadmin2.ib0.cheyenne.ucar.edu (errno=111)
… On Oct 26, 2021, at 8:47 AM, Brian Curtis ***@***.***> wrote:
Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/697940344/20211026084513/ufs-weather-model
Please make changes and add the following label back:
cheyenne-intel-BL
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#714 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RITODRNXL6QQCZSYVLUI25RZANCNFSM5BCNRBUA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Automated RT Failure Notification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready to merge, but I have a few questions going forward:
- What is the plan for enabling debug tests?
- What is the plan for running both prod and debug tests with GNU?
range_warn = .false. | ||
reset_eta = .false. | ||
n_sponge = -1 | ||
nudge_qv = .true. | ||
tau = 0.015 | ||
tau = -5.0e1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does a negative tau
do to the dycore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tau<0 uses the GFS type RF damping, instead of the GFDL type.
@@ -170,8 +171,11 @@ | |||
iopt_tbot = 2 | |||
iopt_stc = 1 | |||
debug = .false. | |||
levr = 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see that the code runs fine with levr < levs
.
Good questions. I guess these tasks should be done by someone who is hired for the WAM development in the future. |
… On Wed, Oct 27, 2021 at 10:08 AM XiaqiongZhou-NOAA ***@***.***> wrote:
This PR is ready to merge, but I have a few questions going forward:
1. What is the plan for enabling debug tests?
2. What is the plan for running both prod and debug tests with GNU?
Good questions. I guess these tasks should be done by someone who is hired
for the WAM development in the future.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKY5N2JQ5IU4RGQTBB3SFLDUJABXFANCNFSM5BCNRBUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
|
Just to be clear, this option was incorrectly coded in FV3 compared to GSM
(fixed to match GSM in my branch).
Moorthi
…On Wed, Oct 27, 2021 at 10:03 AM XiaqiongZhou-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/parm/wam.nml.IN
<#714 (comment)>
:
> range_warn = .false.
reset_eta = .false.
n_sponge = -1
nudge_qv = .true.
- tau = 0.015
+ tau = -5.0e1
tau<0 uses the GFS type RF damping, instead of the GFDL type.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYRQFPBE2RQDWRDW3YDUJABCRANCNFSM5BCNRBUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Fanglin,
We committed the code with Kate's comments. If this configuration is
considered for future WAM implementation, then we need someone to work on
it.
Jun
On Wed, Oct 27, 2021 at 12:00 PM Fanglin Yang ***@***.***>
wrote:
… Jun,
Are #1 and #2 required or optional for this PR being completed ?
On Wed, Oct 27, 2021 at 10:08 AM XiaqiongZhou-NOAA ***@***.***>
wrote:
> This PR is ready to merge, but I have a few questions going forward:
>
> 1. What is the plan for enabling debug tests?
> 2. What is the plan for running both prod and debug tests with GNU?
>
> Good questions. I guess these tasks should be done by someone who is
hired
> for the WAM development in the future.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#714 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKY5N2JQ5IU4RGQTBB3SFLDUJABXFANCNFSM5BCNRBUA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
>
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLITHXBRF6HQGDSJGDUJAOZFANCNFSM5BCNRBUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Jun,
We shall revisit this after the new WAM project is started.
Fanglin
…On Wed, Oct 27, 2021 at 12:06 PM Jun Wang ***@***.***> wrote:
Fanglin,
We committed the code with Kate's comments. If this configuration is
considered for future WAM implementation, then we need someone to work on
it.
Jun
On Wed, Oct 27, 2021 at 12:00 PM Fanglin Yang ***@***.***>
wrote:
> Jun,
>
> Are #1 and #2 required or optional for this PR being completed ?
>
> On Wed, Oct 27, 2021 at 10:08 AM XiaqiongZhou-NOAA ***@***.***>
> wrote:
>
> > This PR is ready to merge, but I have a few questions going forward:
> >
> > 1. What is the plan for enabling debug tests?
> > 2. What is the plan for running both prod and debug tests with GNU?
> >
> > Good questions. I guess these tasks should be done by someone who is
> hired
> > for the WAM development in the future.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#714 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AKY5N2JQ5IU4RGQTBB3SFLDUJABXFANCNFSM5BCNRBUA
> >
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > or Android
> > <
>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> >
> >
>
>
> --
> *Fanglin Yang, Ph.D.*
> *Chief, Model Physics Group*
> *Modeling and Data Assimilation Branch*
>
> *NOAA/NWS/NCEP Environmental Modeling Center*
>
> *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
> <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <
#714 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TLITHXBRF6HQGDSJGDUJAOZFANCNFSM5BCNRBUA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKY5N2LKBRVJQV3CQQ423UDUJAPQHANCNFSM5BCNRBUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
|
Sure.
On Wed, Oct 27, 2021 at 12:53 PM Fanglin Yang ***@***.***>
wrote:
… Jun,
We shall revisit this after the new WAM project is started.
Fanglin
On Wed, Oct 27, 2021 at 12:06 PM Jun Wang ***@***.***> wrote:
> Fanglin,
>
> We committed the code with Kate's comments. If this configuration is
> considered for future WAM implementation, then we need someone to work on
> it.
>
> Jun
>
> On Wed, Oct 27, 2021 at 12:00 PM Fanglin Yang ***@***.***>
> wrote:
>
> > Jun,
> >
> > Are #1 and #2 required or optional for this PR being completed ?
> >
> > On Wed, Oct 27, 2021 at 10:08 AM XiaqiongZhou-NOAA ***@***.***>
> > wrote:
> >
> > > This PR is ready to merge, but I have a few questions going forward:
> > >
> > > 1. What is the plan for enabling debug tests?
> > > 2. What is the plan for running both prod and debug tests with GNU?
> > >
> > > Good questions. I guess these tasks should be done by someone who is
> > hired
> > > for the WAM development in the future.
> > >
> > > —
> > > You are receiving this because you are subscribed to this thread.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
>
#714 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AKY5N2JQ5IU4RGQTBB3SFLDUJABXFANCNFSM5BCNRBUA
> > >
> > > .
> > > Triage notifications on the go with GitHub Mobile for iOS
> > > <
> >
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> > >
> > > or Android
> > > <
> >
>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> > >.
> > >
> > >
> >
> >
> > --
> > *Fanglin Yang, Ph.D.*
> > *Chief, Model Physics Group*
> > *Modeling and Data Assimilation Branch*
> >
> > *NOAA/NWS/NCEP Environmental Modeling Center*
> >
> > *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
> > <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
> >
> > —
> > You are receiving this because you modified the open/close state.
> > Reply to this email directly, view it on GitHub
> > <
>
#714 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AI7D6TLITHXBRF6HQGDSJGDUJAOZFANCNFSM5BCNRBUA
> >
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > or Android
> > <
>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> >
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#714 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKY5N2LKBRVJQV3CQQ423UDUJAPQHANCNFSM5BCNRBUA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
>
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLBKVOKLAKHHZEZJB3UJAU7TANCNFSM5BCNRBUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Orion RT finished successfully while jobs in nems project has a long waiting queue. The RT log is in the RT baseline: /work/noaa/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20211025/RegressionTests_orion.intel.log |
Following the migration to a new site for Jenkins, communication between Jenkins and Hera/Jet have been lost. Guidance from this afternoon (April 5, 2023) says that communication should be returned by CoB today. Reactivating Jet in the Jenkinsfile now.
Description
This PR is to add a WAM regression test with both MULTI_GASES and MOLECULAR_DIFFUSION on. The WAM Molecular diffusion option is to replace Rayleigh Damping in FV3 dycore for deep atmosphere applications. This PR also includes the updates to use GFSv16 configuration for MULTI_GASES.
A new set of model input data is required to be saved at INPUTDATA_ROOT. It is available now at /2year/NCEPDEV/emc-ensemble/Xiaqiong.Zhou/FV3_input_data_149.tar
Issue(s) addressed
Testing
Regression tests had run on Hera with Intel and GNU. A new baseline should be created as the code change in dycore will change the results.
Dependencies
NOAA-EMC/fv3atm#354
NOAA-GFDL/GFDL_atmos_cubed_sphere#120
NCAR/ccpp-physics#712