-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WW3 with 20240116 commit #2550
Update WW3 with 20240116 commit #2550
Conversation
I know that this unexpectedly changes baselines. If there are any additional tests anyone wants to see, please let me know so I can get those started. |
I looked at this commit (for my own curiosity) over the past year. Using mediator history files I found that the first difference arises w/ very very small b4b differences (~10-30) at a single point location for the exported stokes drift components. I think we need to just accept it and move on. |
@JessicaMeixner-NOAA we consider to combine this pr to #2387. |
@jkbk2004 I'll ping on here when the issues are resolved. Thanks again for all of your help! |
@jkbk2004 This PR now needs new input datat: /work2/noaa/marine/jmeixner/hercules/PR_WW3/Jan16/WW3_input_new_2 The WW3 PR has been reviewed by @MatthewMasarik-NOAA and we've addressed the previous failures. |
@JessicaMeixner-NOAA On RDHPCS side, WW3_input_data_20250212 is available under ${INPUTDATA_ROOT}. rt.sh can be updated. |
Thanks @jkbk2004 - It's updated! |
@JessicaMeixner-NOAA can you sync up branch? we can start working on this pr. |
@jkbk2004 - done! Thanks! |
on-behalf-of @ufs-community <[email protected]>
Hercules file system is not stable. But note that baseline was created ok. We will skip Hercules. |
We can start merging process. |
@jkbk2004 - WW3 hash has been updated! |
I think INPUTDATA_ROOT_WW3 needs updating in ufs-weather-model/tests/opnReqTest too (currently |
24e14fd
Commit Queue Requirements:
Description:
This PR updates WW3 (after PR #2549) and isolates the commit that changes answers. This WW3 commit can be seen here: NOAA-EMC/WW3@3952826
Many efforts were made to understand why this PR is changing answers. Different parts of the PR changes were isolated, print statements, etc, were made however so far we have not been able to identify why/what changed. The resulting changes are small. This chnages answers to anything using WW3.
Commit Message:
Update WW3 with 2024-1-16 commit
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
None
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
/work2/noaa/marine/jmeixner/hercules/PR_WW3/Jan16/WW3_input_new_2 -->
${INPUTDATA_ROOT}/WW3_input_data_20250212
Library Changes/Upgrades:
Testing Log: