Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WW3 with 20240116 commit #2550

Merged
merged 26 commits into from
Feb 24, 2025

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jan 6, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates WW3 (after PR #2549) and isolates the commit that changes answers. This WW3 commit can be seen here: NOAA-EMC/WW3@3952826
Many efforts were made to understand why this PR is changing answers. Different parts of the PR changes were isolated, print statements, etc, were made however so far we have not been able to identify why/what changed. The resulting changes are small. This chnages answers to anything using WW3.

Commit Message:

Update WW3 with 2024-1-16 commit

* UFSWM - 
  * WW3 - Update one commit hash

Priority:

  • Normal: Part of a series of PR that has updates needed for GFSv17.

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

None


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • New WW3 Input:
    /work2/noaa/marine/jmeixner/hercules/PR_WW3/Jan16/WW3_input_new_2 -->
    ${INPUTDATA_ROOT}/WW3_input_data_20250212

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@JessicaMeixner-NOAA
Copy link
Collaborator Author

I know that this unexpectedly changes baselines. If there are any additional tests anyone wants to see, please let me know so I can get those started.

@DeniseWorthen
Copy link
Collaborator

I looked at this commit (for my own curiosity) over the past year. Using mediator history files I found that the first difference arises w/ very very small b4b differences (~10-30) at a single point location for the exported stokes drift components. I think we need to just accept it and move on.

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA we consider to combine this pr to #2387.

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 I would like to understand why, if you're looking to combine PRs, the PR for the CoastalApp (#2396) which has no baseline change and which has been waiting since August is not considered higher priority than this one?

uturuncoglu added a commit to uturuncoglu/ufs-weather-model that referenced this pull request Jan 22, 2025
@JessicaMeixner-NOAA
Copy link
Collaborator Author

@jkbk2004 I'll ping on here when the issues are resolved. Thanks again for all of your help!

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@jkbk2004 This PR now needs new input datat:

/work2/noaa/marine/jmeixner/hercules/PR_WW3/Jan16/WW3_input_new_2
to be copied to ${INPUTDATA_ROOT}/WW3_input_data_20250212

The WW3 PR has been reviewed by @MatthewMasarik-NOAA and we've addressed the previous failures.

@DeniseWorthen DeniseWorthen added the New Input Data Req'd This PR requires new data to be sync across platforms label Feb 12, 2025
@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA On RDHPCS side, WW3_input_data_20250212 is available under ${INPUTDATA_ROOT}. rt.sh can be updated.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@JessicaMeixner-NOAA On RDHPCS side, WW3_input_data_20250212 is available under ${INPUTDATA_ROOT}. rt.sh can be updated.

Thanks @jkbk2004 - It's updated!

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA can you sync up branch? we can start working on this pr.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@JessicaMeixner-NOAA can you sync up branch? we can start working on this pr.

@jkbk2004 - done! Thanks!

@jkbk2004 jkbk2004 added the jenkins-ort run ORT testing label Feb 20, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA removed the jenkins-ort run ORT testing label Feb 20, 2025
@jkbk2004 jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 20, 2025
@jkbk2004
Copy link
Collaborator

Hercules file system is not stable. But note that baseline was created ok. We will skip Hercules.

@jkbk2004
Copy link
Collaborator

We can start merging process.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@jkbk2004 - WW3 hash has been updated!

jkbk2004
jkbk2004 previously approved these changes Feb 21, 2025
@NickSzapiro-NOAA
Copy link
Collaborator

I think INPUTDATA_ROOT_WW3 needs updating in ufs-weather-model/tests/opnReqTest too (currently INPUTDATA_ROOT_WW3=${INPUTDATA_ROOT}/WW3_input_data_20240214/ )

@jkbk2004 jkbk2004 dismissed stale reviews from FernandoAndrade-NOAA and themself via 24e14fd February 23, 2025 23:58
@jkbk2004 jkbk2004 merged commit ad1c0d2 into ufs-community:develop Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants