-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few miscellaneous minor fixes to regression test scripts #2301
Closed
DusanJovic-NOAA
wants to merge
7
commits into
ufs-community:develop
from
DusanJovic-NOAA:random_rt_fixes
Closed
A few miscellaneous minor fixes to regression test scripts #2301
DusanJovic-NOAA
wants to merge
7
commits into
ufs-community:develop
from
DusanJovic-NOAA:random_rt_fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update wording on failed tests/compiles, added skipped tests when compile fails and math adjustments, adjusted grep for TIME LIMIT when a compile/test times out. * removed commented lines and added TIME LIMIT to test section as well * edit log file info for timeout tests
Regression test passed on Hera RegressionTests_hera.log |
14 tasks
@FernandoAndrade-NOAA @zach1221 I think we need to go for testing this pr (not to combine with #2271). @BrianCurtis-NOAA FYI |
Do we want to combine this into my WCOSS2 PR ? |
@BrianCurtis-NOAA Good idea to combine with that! Please, go ahead. |
14 tasks
BrianCurtis-NOAA
approved these changes
May 31, 2024
zach1221
pushed a commit
that referenced
this pull request
May 31, 2024
) * UFSWM - A few miscellaneous minor fixes to regression test scripts - Bring in changes for WCOSS2 to match the spack-stack 1.6.0 setup - Bring in updated pnetcdf/pio for CICE - Print 'ECFLOW Tasks Remaining' message only when the number of tasks changes - Remove explicit 'set -e'. Use -v command line option for verbose mode - Remove 'Computing PET bounds and tasks' message - Fix bugs with log generation script (from @BrianCurtis-NOAA) - Uncomment new_compile=true in rocoto_create_compile_task - Removed unneeded colonifnco
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR includes a number of small changes in rt scripts, mostly code cleanup and changes that reduce the amount of prints to stdout
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: