Update diag_table for global coupled iau test for mom6 history output

[junwang-noaa]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

Update diag_able in cpld_control_gfsv17_iau to output MOM6 history file in correct time.

This PR can be combined with other PRs that change results.

Commit Message

Update diag_able for global coupled iau test cpld_control_gfsv17_iau for mom6 history output

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
• Normal

Blocking Dependencies

No.

Git Issues Fixed By This PR

Closes #2089

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• [ x] Changes are expected to the following tests: cpld_control_gfsv17_iau

FAILED REGRESSION TESTS

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[DeniseWorthen]

@junwang-noaa Should we try to also fix #2084 and update all the diag_tables to at least let G-W have MOM6 output in a separate directory? I'm not sure how to resolve the ATM output directory.

[junwang-noaa]

Pre-test results are on Hera at: /scratch1/NCEPDEV/nems/Jun.Wang/nems/vlab/20240108/ufs-weather-model/tests/logs/RegressionTests_hera.log
All 236 tests passed. the cpld_control_gfsv17_iau_intel failed because of missing baseline.

FAILED TESTS:
003 cpld_control_gfsv17_iau_intel failed in check_result
cpld_control_gfsv17_iau_intel 003 failed in run_test

[DeniseWorthen]

@junwang-noaa Do we really want to move the output location for MOM6 in the RT? I thought the idea is that w/ the MOM6_OUPUT_DIR variable defined, G-W can use MOM6_OUPUT but RTs can continue to write directly to the run directory.

[junwang-noaa]

I think it is good to have consistent output structure between RT and G-W.

[DeniseWorthen]

But we're not keeping consistent w/rt the RESTART directories or the other component output directories. We specifically made this a variable which could be configured for the RTs independently of where G-W prefers to have their output, restarts etc.

[BrianCurtis-NOAA]

Is it possible/worth it to have components output to their own directory and keep it consistent in the restarts?

[DeniseWorthen]

I don't understand the advantage for the RT to do that. As I said, we made them variables so that each system can specify them the way that works best of them. The RT is not the G-W.

[junwang-noaa]

The goal is to help developers integrate their updates to UFS WM and G-W easily, having same values in RT and GW helps us to do that . There is some offline discussion. @DeniseWorthen please let me know if you still have any concerns.

[DeniseWorthen]

@junwang-noaa Why are we not making this change in the remaining diag_tables that contain MOM6 output fields? I see OCN output in diag_table_p8_gocart_micro and diag_table_p8_template and diag_table_template. If those are not being used anymore then perhaps we should remove them.

I also wonder whether we should take the chance to rename these template files to .IN files (as was done for ice_in etc). So diag_table_cpld_template_iau would become diag_table_cpld_iau.IN

[junwang-noaa]

@DeniseWorthen Updated, please review.

[junwang-noaa]

@jkbk2004 Please let me know if PR#2107 will be combined with this one.

[zach1221]

@jkbk2004 Please let me know if PR#2107 will be combined with this one.

I think we do want to combine, I've just requested the branch be synced up on 2107.

[zach1221]

@junwang-noaa 2107 is going to take some additional time, due to review of the ccpp-physics sub-pr. If you can sync up your branch here, then we'll just do this PR by itself.

[junwang-noaa]

@zach1221 My branch is updated.

[zach1221]

Apologies for the delay, testing is complete. Sending out final reviews.