-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore empty fv3atm output bundle #1825
Ignore empty fv3atm output bundle #1825
Conversation
@DusanJovic-NOAA We consider to combine this pr with #1811. can you sync up branch? so we can prepare. |
@DusanJovic-NOAA Once #1815 is ready, we will let #1815 go first though. |
My branches are updated. |
@DusanJovic-NOAA Can you take a look at /scratch1/NCEPDEV/stmp2/Jong.Kim/FV3_RT/rt_98984/rrfs_smoke_conus13km_fast_phy32_qr_intel ? It crashes. |
I just updated FV3 submodule. |
Hello, @DusanJovic-NOAA . PR 1794 has been merged. Can you sync up your branch with develop and resolve conflicts here? That way we can begin testing through this PR next. |
@DusanJovic-NOAA @zach1221 could we add #1813 to this? |
I'm ok with that, if Dusan is. I can just copy over the template and commit directly to this PR. |
I'm also ok with that. |
Jenkins ci log is attached, ORTs passed. |
Testing is complete. I'll follow up on the fv3atm sub-pr to begin the merging process. |
New FV3 hash: NOAA-EMC/fv3atm@1158696 |
@DusanJovic-NOAA fv3atm sub-pr #679 has been merged. Please update the submodule point revert the change in gitmodules. |
Closes #1813 |
Description
Fix model crash if one or the fv3atm output bundles does not have any field. See: NOAA-EMC/fv3atm#676
Input data additions/changes
Anticipated changes to regression tests:
Subcomponents involved:
Library Updates/Changes
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Depends on NOAA-EMC/fv3atm/issues/676
Testing Day Checklist:
Testing Log (for CM's):