Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up gitaction yml #1552

Merged
merged 16 commits into from
Jan 3, 2023
Merged

clean up gitaction yml #1552

merged 16 commits into from
Jan 3, 2023

Conversation

jkbk2004
Copy link
Collaborator

@jkbk2004 jkbk2004 commented Dec 30, 2022

Description

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@jkbk2004 jkbk2004 added the No Baseline Change No Baseline Change label Dec 30, 2022
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change and removed No Baseline Change No Baseline Change labels Dec 30, 2022
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change and removed No Baseline Change No Baseline Change labels Dec 30, 2022
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change and removed No Baseline Change No Baseline Change labels Dec 30, 2022
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change and removed No Baseline Change No Baseline Change labels Dec 30, 2022
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change and removed No Baseline Change No Baseline Change labels Dec 30, 2022
@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Jan 2, 2023

@BrianCurtis-NOAA @zach1221 I created this pr to fix the issue of gitaction failures. The issue seems to be originated somewhere from pre job step in aux.yml. Once pre runs ok, it will create id_file w/o problem. I tested ok the cleanup of aux.yml with my personal git setup. No impact on other tests at all. so we can try to merge in tomorrow as a hot fix.

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Jan 2, 2023

The key point is to clean up some of outdated lines like deleting run-ci labels in aux.yml

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkbk2004 Is the github repo check only checking fv3 submodule now? If so, we want to check all sub component repos. Maybe this is being worked on though?

Also I don't see a reason to overwrite the previous UFS RT logs. Please remove those.

@jkbk2004 jkbk2004 merged commit 5d66bca into ufs-community:develop Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants