-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fms to fms/2022.04 and add a coupled mixed-mode test #1514
Conversation
@binli2337 I don't see the added test in the PR. Will it compare against the non-mixed mode baseline? |
@DeniseWorthen I just added the test. Thanks! |
Thanks @binli2337. So the baseline change is only because a test is being added. All other coupled tests do not use mixed-mode and should reproduce the current baselines, right? Do we know that the mixed-mode test passes the ORTs? |
@DeniseWorthen You are correct. All other tests can reproduce existing baselines. The ORT tests passed a few months ago. The ORT tests have not been run for this PR. |
Automated RT Failure Notification |
@BrianCurtis-NOAA if wcoss2 is skipped, we can start merging process. |
the atmaq tests failed, but it seems it may have been a machine issue. I'm running them again now. If successful i'll push in a little bit. |
@jkbk2004 I don't see the log on wcoss2 yet. Have the tests on wcoss2 passed? |
I'm running 2 failed tests again. Should commit shortly if passed. |
@BrianCurtis-NOAA Thanks! |
@binli2337 we can merge in cubed sphere pr 163. I am moving there to ask for the merge. |
@binli2337 the fv3 dependency was merged. let's finish merging on this side. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Co-authored-by @junwang-noaa