Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRL Neptune model 32-bit physics support #1206

Closed

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented May 6, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

Adds ccpp-physics changes needed to support 32-bit physics on Neptune. This does not add 32-bit physics to FV3, which requires quite a lot more changes in several repositories.

Issue(s) addressed

Implements what this PR was supposed to:

NCAR/ccpp-physics#797

Which is about half of this batch of changes from NRL:

NCAR/ccpp-physics#772

Testing

Original testing was done on Neptune model by NRL. After that, it was tested in UFS, with these changes disabled. Finally, another set of branches (not in this PR) were developed that can successfully compile UFS for 32-bit physics, but not yet run it that way.

  • hera.intel (cannot test because Hera stmp is full)
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

NCAR/ccpp-physics#918
NOAA-EMC/fv3atm#532

@SamuelTrahanNOAA
Copy link
Collaborator Author

As of this posting, this PR is up-to-date with all components and has passed intel compiler tests (on jet) and gnu compiler tests (on hera).

@SamuelTrahanNOAA
Copy link
Collaborator Author

I have changed the .gitmodules from ssh to https due to permission problems.

@BrianCurtis-NOAA
Copy link
Collaborator

This will be merged into #1227

@SamuelTrahanNOAA
Copy link
Collaborator Author

This will be merged into #1227

Not yet. It is failing after the cleanup of machine.F. I have a fix, and I am testing it now.

@BrianCurtis-NOAA
Copy link
Collaborator

This will be merged into #1227

Not yet. It is failing after the cleanup of machine.F. I have a fix, and I am testing it now.

We would just be merging in your .gitmodules changes. I will wait until you give me the OK before I run RT's in that PR though.

@SamuelTrahanNOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA It works now. The issue was in FV3/ccpp/physics/machine.F, not the .gitmodules.

@BrianCurtis-NOAA
Copy link
Collaborator

I thought the other PR would have closed this. This was merged in #1227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants