-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring exchange grid support to UFS #1157
Bring exchange grid support to UFS #1157
Conversation
…lu/ufs-weather-model into feature/xgrid_dev_host
@uturuncoglu cmeps branch merged. Can you create fv3atm PR to NOAA-EMC/fv3atm develop to merge in your feature branch? |
@uturuncoglu Oh! we have fv3atm PR already. #517. Sounds like ccpp PRs should be merged in first. |
@uturuncoglu can you coordinate with @grantfirl to merge in your ccpp PRs? |
@jkbk2004 I add comment to CCPP PR about it. Thanks for your help. |
@jkbk2004 I updated FV3 PR CCPP submodule pointers after merging CCPP physics and framework PRs. I think FV3 PR is ready to merge. |
…lu/ufs-weather-model into feature/xgrid_dev_host
FV3 merged: Hash 5117434 |
@DusanJovic-NOAA @junwang-noaa This PR is ready to merge in. Can you leave the review comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, submodule pointers may still need to be updated.
@jkbk2004 Make sure @uturuncoglu updates this PR with the new hash of FV3 and updates .gitmodules before you merge it into develop branch. |
@uturuncoglu Can you pull in hash update and revert gitmodule pointers? |
@@ -19,6 +19,10 @@ RUN | cpld_restart_bmark_p8 | |||
COMPILE | -DAPP=S2SWA -DDEBUG=ON -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 | - wcoss_cray wcoss2.intel | fv3 | | |||
RUN | cpld_debug_p8 | - wcoss_cray wcoss2.intel | fv3 | | |||
|
|||
# Waves and aerosol off for computing fluxes in mediator | |||
COMPILE | -DAPP=S2S -DCCPP_SUITES=FV3_GFS_v17_coupled_p8_sfcocn -DCMEPS_AOFLUX=ON | - wcoss_cray | fv3 | | |||
RUN | cpld_control_noaero_p8_agrid | - wcoss_cray | fv3 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think previous cpld_control_noaero_p8 does not have wave, but it was updated to include wave in the latest develop branch. Maybe we can consider changing the test name or enabling this exchange grid test to include wave and aerosol later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junwang-noaa I did not know it. It could be nice to update it to be consistent with the existing configurations. We could rename the test but that will require creating baselines again or at least changing folder names. Let me know what do you think? If you want to rename the test, do you have any name in your mind. Thanks.
@junwang-noaa @climbfuji @jkbk2004 Both FV3 and CMEPS submodules are updated to point NOAA/EMC repos. |
@uturuncoglu Please see my comments, do you think the exchange grid can work with cpld_control_p8 test with wave and aerosol? Maybe in the future, we want to change the cpld_control_noaero_p8_agrid to cpld_control_p8. Thanks |
@junwang-noaa yes. it will work with cpld_control_p8 without any issue. |
@junwang-noaa @climbfuji @jkbk2004 @MinsukJi-NOAA @DusanJovic-NOAA @DeniseWorthen Thanks all of you for your help. |
Champagne time!!! |
Awesome work everyone getting this one in. This required a lot of collaboration and a lot of software components. @uturuncoglu congratulations on delivering this substantial new capability into the UFS! |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
The PR aims to bring exchange grid capability, which is provided by CMEPS mediator, to the UFS weather model. The PR includes following major changes in the model;
nems.configure
and needs to be placedMED_attributes::
section.nems_frac_aoflux
, It allows to pass mediator calculated atmosphere-ocean fluxes to FV3nems_frac_aoflux_sbs
, This mode is just for side-by-side comparisons of fluxes calculated on FV3/CCPP and CMEPS/CCPP. In this mode, the fluxes are calculated under mediator but not sent to FV3. So, the results of fully coupled model has no answer change since the fluxes does not received by FV3 but the mediator history files will include also fluxes calculated under mediator.nems.configure
and default values works but it might be required in the near future when external land component brings in.true
.1
.true
.2
.true
.false
) or a warmstart/restart (true
). The default value istrue
.true
.true
.true
.start_type = 'continue'
), then CCPP host model uses internally calculated file name.INPUT/sfc_data.tile
. Note that there is no need to specify tile no.ccpp_ini_mosaic_file
. The default value isINPUT/
3,8
.input.nml
option (use_med_flux
) is added togfs_physics_nml
group. The default value is .false. and the FV3/CCPP Physics will no accept any flux from external sources such as CMEPS. This allow to preserve the existing functionality in the FV3 side.cpld_control_c96_noaero_p8_xgrid
) is also implemented to test the exchange grid functionality. The baseline needs to be placed into the common input and baseline directory. There is no need to have separate input file for this test since it is just a derivative ofcpld_control_c96_noaero_p8
.Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
The model is tested on NCAR's Cheyenne platform with intel compiler. All regression tests are passing at this point.
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs