-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add GDAS and GEFS datasets to the workflow #526
Changes from all commits
9ae8a96
c6bd39b
1d070ed
710e4ee
a853888
26946d1
cfc8cd8
a4e322a
f6e0d3b
4af4c96
85ab1d7
1117866
8b5d428
44385cf
6952c47
ec969cb
39a9bcd
cef51f0
d5cb371
6d96e2c
d68e685
87aaa9c
49552c4
c66236a
420080d
aa15def
57df940
517e660
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,10 +84,10 @@ fi | |
#----------------------------------------------------------------------- | ||
# | ||
if [ $RUN_ENVIR = "nco" ]; then | ||
extrn_mdl_staging_dir="${COMINext}" | ||
extrn_mdl_staging_dir="${COMINext}${SLASH_ENSMEM_SUBDIR}" | ||
extrn_mdl_var_defns_fp="${extrn_mdl_staging_dir}/${NET}.${cycle}.${EXTRN_MDL_NAME_LBCS}.LBCS.${EXTRN_MDL_VAR_DEFNS_FN}.sh" | ||
else | ||
extrn_mdl_staging_dir="${COMIN}/${EXTRN_MDL_NAME_LBCS}/for_LBCS" | ||
extrn_mdl_staging_dir="${COMIN}/${EXTRN_MDL_NAME_LBCS}/for_LBCS${SLASH_ENSMEM_SUBDIR}" | ||
extrn_mdl_var_defns_fp="${extrn_mdl_staging_dir}/${EXTRN_MDL_VAR_DEFNS_FN}.sh" | ||
fi | ||
. ${extrn_mdl_var_defns_fp} | ||
|
@@ -129,6 +129,8 @@ case "${CCPP_PHYS_SUITE}" in | |
varmap_file="GSDphys_var_map.txt" | ||
elif [ "${EXTRN_MDL_NAME_LBCS}" = "NAM" ] || \ | ||
[ "${EXTRN_MDL_NAME_LBCS}" = "FV3GFS" ] || \ | ||
[ "${EXTRN_MDL_NAME_LBCS}" = "GEFS" ] || \ | ||
[ "${EXTRN_MDL_NAME_LBCS}" = "GDAS" ] || \ | ||
[ "${EXTRN_MDL_NAME_LBCS}" = "GSMGFS" ]; then | ||
varmap_file="GFSphys_var_map.txt" | ||
fi | ||
|
@@ -291,6 +293,20 @@ case "${EXTRN_MDL_NAME_LBCS}" in | |
fi | ||
;; | ||
|
||
"GDAS") | ||
tracers_input="[\"spfh\",\"clwmr\",\"o3mr\",\"icmr\",\"rwmr\",\"snmr\",\"grle\"]" | ||
tracers="[\"sphum\",\"liq_wat\",\"o3mr\",\"ice_wat\",\"rainwat\",\"snowwat\",\"graupel\"]" | ||
external_model="GFS" | ||
input_type="gaussian_netcdf" | ||
fn_atm="${EXTRN_MDL_FNS[0]}" | ||
;; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like we may need additional logic to allow LBCS to be nemsio format given the namelist entries in RRFS_dev1. That could be a part of a future PR, though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I only see a 'gaussian_netcdf' as the input type for GDAS in the RRFS_dev1 file. Maybe I'm not looking at the right location?? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, but there are 2 entries present at the file at that link for Those entries are also present in the case statement below, too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, I gotcha. In the develop branch,
Is this what you are looking for? My apologies for not fully understanding this request. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, sorry, I should have been more explicit. In the RRFS_dev1 version, under GDAS on line 337, there are these entries:
In your addition of GDAS here, you've added a single |
||
|
||
"GEFS") | ||
external_model="GFS" | ||
fn_grib2="${EXTRN_MDL_FNS[0]}" | ||
input_type="grib2" | ||
;; | ||
|
||
"RAP") | ||
external_model="RAP" | ||
input_type="grib2" | ||
|
@@ -364,6 +380,12 @@ for (( i=0; i<${num_fhrs}; i++ )); do | |
fn_atm="${EXTRN_MDL_FNS[$i]}" | ||
fi | ||
;; | ||
"GDAS") | ||
fn_atm="${EXTRN_MDL_FNS[0][$i]}" | ||
;; | ||
"GEFS") | ||
fn_grib2="${EXTRN_MDL_FNS[$i]}" | ||
;; | ||
"RAP") | ||
fn_grib2="${EXTRN_MDL_FNS[$i]}" | ||
;; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
metadata: | ||
description: |- | ||
This test checks the capability of the workflow to retrieve from NOAA | ||
AWS grib2-formatted output files generated by GEFS. | ||
user: | ||
RUN_ENVIR: community | ||
platform: | ||
EXTRN_MDL_DATA_STORES: aws | ||
workflow: | ||
CCPP_PHYS_SUITE: FV3_HRRR | ||
PREDEF_GRID_NAME: RRFS_CONUS_3km | ||
DATE_FIRST_CYCL: '2022040400' | ||
DATE_LAST_CYCL: '2022040400' | ||
FCST_LEN_HRS: 6 | ||
PREEXISTING_DIR_METHOD: rename | ||
task_get_extrn_ics: | ||
EXTRN_MDL_NAME_ICS: GEFS | ||
EXTRN_MDL_ICS_OFFSET_HRS: 6 | ||
FV3GFS_FILE_FMT_ICS: grib2 | ||
task_get_extrn_lbcs: | ||
EXTRN_MDL_NAME_LBCS: GEFS | ||
LBC_SPEC_INTVL_HRS: 6 | ||
EXTRN_MDL_LBCS_OFFSET_HRS: 0 | ||
FV3GFS_FILE_FMT_LBCS: grib2 | ||
global: | ||
DO_ENSEMBLE: true | ||
NUM_ENS_MEMBERS: 2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
metadata: | ||
description: |- | ||
This test checks the capability of the workflow to retrieve from NOAA | ||
HPSS netcdf-formatted output files generated by GDAS. | ||
user: | ||
RUN_ENVIR: community | ||
platform: | ||
EXTRN_MDL_DATA_STORES: hpss | ||
workflow: | ||
CCPP_PHYS_SUITE: FV3_HRRR | ||
PREDEF_GRID_NAME: RRFS_CONUS_3km | ||
DATE_FIRST_CYCL: '2022040400' | ||
DATE_LAST_CYCL: '2022040400' | ||
FCST_LEN_HRS: 6 | ||
PREEXISTING_DIR_METHOD: rename | ||
task_get_extrn_ics: | ||
EXTRN_MDL_NAME_ICS: GDAS | ||
EXTRN_MDL_ICS_OFFSET_HRS: 6 | ||
FV3GFS_FILE_FMT_ICS: netcdf | ||
task_get_extrn_lbcs: | ||
EXTRN_MDL_NAME_LBCS: GDAS | ||
LBC_SPEC_INTVL_HRS: 6 | ||
EXTRN_MDL_LBCS_OFFSET_HRS: 0 | ||
FV3GFS_FILE_FMT_LBCS: netcdf | ||
global: | ||
DO_ENSEMBLE: true | ||
NUM_ENS_MEMBERS: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic doesn't appear to work correctly for ensemble cases. When I ran a test ensemble case (community_ensemble_008mems), the script fails with the following error:
Full experiment on Jet here:
/mnt/lfs4/HFIP/dtc-hurr/kavulich/workdir/PR_526/expt_dirs/community_ensemble_008mems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mike, no worries! I updated my fork branch to the latest
develop
branch. I also found a bug in the code that was causing this error (line 347 neededmembers
to be defined ascla.members
. It should run through now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it appears to be working now!