Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Patch to correct a variable name to a lower-case #468

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

natalie-perlin
Copy link
Collaborator

@natalie-perlin natalie-perlin commented Nov 11, 2022

DESCRIPTION OF CHANGES:

Running plotting script throws an error when new miniconda/python are used.
The fix is to use the lower-case name of the one of the plotted variables.

The fix originally found and applied by @EdwardSnyder-NOAA , tested by
@BruceKropp-Raytheon . The fix was limited to applying it using "sed" at the time of plotting.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

@BruceKropp-Raytheon was performing testing

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@EdwardSnyder-NOAA @BruceKropp-Raytheon @gspetro-NOAA

Updating a variable name "Geopotential Height" to "Geopotential height". Lower-case is needed for it to work with a newer Python.
Updating a variable name "Geopotential Height" to "Geopotential height" (lower-case). This is needed to work with newer Python
@MichaelLueken
Copy link
Collaborator

@natalie-perlin Similar to PR #467, please make sure that another PR is created to get this update into the release/public-v2.1.0 branch as well. Otherwise, neither PR #467 nor this work will be in the SRW v2.1 release.

@MichaelLueken MichaelLueken added the bug Something isn't working label Nov 11, 2022
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following was added by Bruce Kropp in the Jenkins configuration file on all platforms:

sed -i 's/Geopotential Height/Geopotential height/g' ./ush/Python/plot_allvars.py

This is done so the plotting script can run via Jenkins. It'll fail because the height in GH is now lower case. It sounds like there was a change in how the NetCDF file displays GH and the proper changes didn't make into the plotting script.

This update corrects the inconsistency in Geopotential height for plot_allvars.py, so approving this PR.

@JeffBeck-NOAA JeffBeck-NOAA changed the title Patch to correct a variable name to a lower-case [develop] Patch to correct a variable name to a lower-case Nov 11, 2022
@MichaelLueken
Copy link
Collaborator

@natalie-perlin To create a branch off of the release/public-v2.1.0 branch to add these changes and the changes from PR #467, please use the following steps:

  1. git remote add upstream https://github.com/ufs-community/ufs-srweather-app.git
  2. git remote update
  3. git checkout upstream/release/public-v2.1.0 -b release/public-v2.1.0_macos

You will now be in the release/public-v2.1.0_macos branch in your fork, where you can apply the modifications from PR #467. You can do this for this PR as well. Then, make sure that you choose to merge the changes into release/public-v2.1.0 rather than develop when you create a PR.

Please let me know if you have any questions or need assistance.

@MichaelLueken MichaelLueken merged commit b839658 into develop Nov 14, 2022
@MichaelLueken MichaelLueken deleted the plotting-patch-1 branch September 12, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants