-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Patch to correct a variable name to a lower-case #468
Conversation
Updating a variable name "Geopotential Height" to "Geopotential height". Lower-case is needed for it to work with a newer Python.
Updating a variable name "Geopotential Height" to "Geopotential height" (lower-case). This is needed to work with newer Python
@natalie-perlin Similar to PR #467, please make sure that another PR is created to get this update into the release/public-v2.1.0 branch as well. Otherwise, neither PR #467 nor this work will be in the SRW v2.1 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following was added by Bruce Kropp in the Jenkins configuration file on all platforms:
sed -i 's/Geopotential Height/Geopotential height/g' ./ush/Python/plot_allvars.py
This is done so the plotting script can run via Jenkins. It'll fail because the height in GH is now lower case. It sounds like there was a change in how the NetCDF file displays GH and the proper changes didn't make into the plotting script.
This update corrects the inconsistency in Geopotential height for plot_allvars.py, so approving this PR.
@natalie-perlin To create a branch off of the release/public-v2.1.0 branch to add these changes and the changes from PR #467, please use the following steps:
You will now be in the release/public-v2.1.0_macos branch in your fork, where you can apply the modifications from PR #467. You can do this for this PR as well. Then, make sure that you choose to merge the changes into release/public-v2.1.0 rather than develop when you create a PR. Please let me know if you have any questions or need assistance. |
DESCRIPTION OF CHANGES:
Running plotting script throws an error when new miniconda/python are used.
The fix is to use the lower-case name of the one of the plotted variables.
The fix originally found and applied by @EdwardSnyder-NOAA , tested by
@BruceKropp-Raytheon . The fix was limited to applying it using "sed" at the time of plotting.
Type of change
TESTS CONDUCTED:
@BruceKropp-Raytheon was performing testing
DEPENDENCIES:
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@EdwardSnyder-NOAA @BruceKropp-Raytheon @gspetro-NOAA