Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update weather model hash to 8933749 (February 19) and add smoke/dust WE2E test to testing suites #1195

Merged

Conversation

MichaelLueken
Copy link
Collaborator

@MichaelLueken MichaelLueken commented Feb 7, 2025

DESCRIPTION OF CHANGES:

  • Update weather model hash to 8933749 from February 19, 2025
  • Add smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf WE2E test to coverage.gaea-c6, comprehensive and comprehensive.orion (sym linked to comprehensive.gaea-c6 and comprehensive.hercules)
  • Add:
load(pathJoin("nco", os.getenv("nco_ver") or "5.0.6"))
load(pathJoin("prod_util", os.getenv("prod_util_ver") or "2.1.1"))

to modulefiles/build_hera_gnu.lua.

  • Address documentation failures now that https://www.fvcom.org site's security certificate has been renewed
  • Change gaea to gaeac5 and gaea-c6 to gaeac6 throughout to address node name change in Jenkins
  • Remove Jet support in Jenkins

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

TESTS CONDUCTED:

  • derecho.intel - Comprehensive, Fire, and AQM WE2E tests
  • gaea.intel - Comprehensive and Fire WE2E tests
  • gaea-c6.intel - Comprehensive and Fire WE2E tests
  • hera.gnu - Comprehensive and Fire WE2E tests
  • hera.intel - Comprehensive, Fire, and AQM WE2E tests
  • hercules.intel - Comprehensive, Fire, and AQM WE2E tests
  • orion.intel - Comprehensive, Fire, and AQM WE2E tests
  • Jenkins - Fire and AQM WE2E tests were run using the new srw-fire-aqm Jenkins pipeline
  • comprehensive tests - All comprehensive tests were run and the new smoke/dust WE2E was added on machines that support the capability

DOCUMENTATION:

Updated documentation to address failures in the Doc Tests following the renewal of the https://www.fvcom.org security certificate

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes

MichaelLueken and others added 10 commits January 31, 2025 18:20
…0 (January 28, 2025) and add smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf to tests/WE2E/machine_suites/comprehensive
…e_HRRR_gf to tests/WE2E/machine_suites/comprehensive.orion and replace sym link for tests/WE2E/machine_suites/comprehensive.gaea (can't run smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf on Gaea-C5)
…o allow the smoke_dust WE2E test to run on Hera using GNU-built executables
…e_HRRR_gf WE2E test to coverage.gaea-c6 test suite
…ion now that the security certificate for https://www.fvcom.org has been renewed
…o the list of mocked modules for building documentation
@MichaelLueken MichaelLueken marked this pull request as ready for review February 19, 2025 20:43
@MichaelLueken
Copy link
Collaborator Author

The comprehensive WE2E tests were run on Hera and successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
2020_CAD_20250219194541                                            COMPLETE              67.94
2020_CAPE_20250219194542                                           COMPLETE              70.25
2019_hurricane_barry_20250219194542                                COMPLETE              70.68
2019_halloween_storm_20250219194543                                COMPLETE              68.63
2019_hurricane_lorenzo_20250219194544                              COMPLETE              71.03
2019_memorial_day_heat_wave_20250219194544                         COMPLETE              65.56
2020_denver_radiation_inversion_20250219194545                     COMPLETE              68.67
2020_easter_storm_20250219194546                                   COMPLETE              70.09
2020_jan_cold_blast_20250219194547                                 COMPLETE              71.21
community_20250219194547                                           COMPLETE              37.83
custom_ESGgrid_20250219194548                                      COMPLETE              33.29
custom_ESGgrid_Central_Asia_3km_20250219194549                     COMPLETE              61.85
custom_ESGgrid_Great_Lakes_snow_8km_20250219194549                 COMPLETE              26.50
custom_ESGgrid_IndianOcean_6km_20250219194551                      COMPLETE              35.00
custom_ESGgrid_NewZealand_3km_20250219194552                       COMPLETE             130.92
custom_ESGgrid_Peru_12km_20250219194552                            COMPLETE              43.38
custom_ESGgrid_SF_1p1km_20250219194553                             COMPLETE             400.49
custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE_202  COMPLETE              15.12
custom_GFDLgrid_20250219194554                                     COMPLETE              14.52
deactivate_tasks_20250219194555                                    COMPLETE               1.48
get_from_AWS_ics_GEFS_lbcs_GEFS_fmt_grib2_2022040400_ensemble_2me  COMPLETE            1709.21
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200_2025021  COMPLETE              11.41
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2019061200_202502  COMPLETE              14.04
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2021032018_202502  COMPLETE              14.18
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_netcdf_2022060112_48h_20  COMPLETE             123.79
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2  COMPLETE            1769.12
get_from_HPSS_ics_GSMGFS_lbcs_GSMGFS_20250219194600                COMPLETE              11.77
get_from_HPSS_ics_HRRR_lbcs_RAP_20250219194601                     COMPLETE              24.39
get_from_HPSS_ics_RAP_lbcs_RAP_20250219194602                      COMPLETE              28.02
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS_20250219194603              COMPLETE              18.30
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_202  COMPLETE              15.72
grid_CONUS_3km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_  COMPLETE             630.40
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20250  COMPLETE             160.47
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20250219194606  COMPLETE             416.03
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250219194  COMPLETE              55.32
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              75.80
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025021919  COMPLETE              62.10
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              63.57
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE               8.90
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              28.59
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              28.31
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025021919  COMPLETE              13.14
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250219194  COMPLETE              64.97
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              29.94
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP_20250219194615  COMPLETE              17.26
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2_20250  COMPLETE              12.59
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025021919461  COMPLETE              51.50
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_RRFS_v1beta_202502191  COMPLETE              26.82
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_202502  COMPLETE             543.22
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             754.37
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_20250219  COMPLETE             719.60
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20250219194  COMPLETE             860.44
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_2025  COMPLETE             853.15
grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              65.00
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR_20250219  COMPLETE              64.64
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              63.40
grid_RRFS_CONUScompact_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              18.99
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025021  COMPLETE              60.44
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              16.47
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_v1beta_  COMPLETE              20.61
grid_RRFS_CONUScompact_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_2  COMPLETE             635.88
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR_202502191  COMPLETE             756.26
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             778.25
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250219194632  COMPLETE             168.35
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0_202502  COMPLETE              58.33
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025021919463  COMPLETE              37.99
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250219194  COMPLETE              27.80
grid_SUBCONUS_Ind_3km_ics_NAM_lbcs_NAM_suite_GFS_v16_202502191946  COMPLETE              42.37
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              19.27
long_fcst_20250219194639                                           COMPLETE             205.64
MET_ensemble_verification_only_vx_20250219194639                   COMPLETE               1.31
MET_ensemble_verification_only_vx_time_lag_20250219194643          COMPLETE               4.50
MET_ensemble_verification_winter_wx_20250219194645                 COMPLETE             216.96
MET_verification_only_vx_20250219194647                            COMPLETE               0.32
pregen_grid_orog_sfc_climo_20250219194650                          COMPLETE              12.55
smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf_20250219194652        COMPLETE            2072.23
specify_EXTRN_MDL_SYSBASEDIR_ICS_LBCS_20250219194653               COMPLETE              12.21
specify_template_filenames_20250219194653                          COMPLETE              13.13
vx-det_long-fcst_custom-vx-config_aiml-fourcastnet_20250219194654  COMPLETE               0.69
vx-det_long-fcst_custom-vx-config_aiml-graphcast_20250219194656    COMPLETE               0.69
vx-det_long-fcst_custom-vx-config_aiml-panguweather_2025021919465  COMPLETE               0.69
vx-det_long-fcst_custom-vx-config_gfs_20250219194701               COMPLETE               0.71
vx-det_long-fcst_winter-wx_SRW-staged_20250219194703               COMPLETE               1.28
vx-det_multicyc_fcst-overlap_ncep-hrrr_20250219194706              COMPLETE               3.92
vx-det_multicyc_first-obs-00z_ncep-hrrr_20250219194708             COMPLETE               0.92
vx-det_multicyc_last-obs-00z_ncep-hrrr_20250219194710              COMPLETE               1.00
vx-det_multicyc_long-fcst-no-overlap_nssl-mpas_20250219194712      COMPLETE              13.72
vx-det_multicyc_long-fcst-overlap_nssl-mpas_20250219194715         COMPLETE              12.58
vx-det_multicyc_no-00z-obs_nssl-mpas_20250219194717                COMPLETE               0.87
vx-det_multicyc_no-fcst-overlap_ncep-hrrr_20250219194720           COMPLETE               2.16
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE           16053.01

The coverage tests successfully passed on Gaea-C6:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
community_20250219154300                                           COMPLETE              24.41
custom_ESGgrid_NewZealand_3km_20250219154300                       COMPLETE              82.93
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              80.36
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250219154  COMPLETE              65.20
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025021915  COMPLETE              66.75
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE            4612.45
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025021  COMPLETE             210.34
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE            5606.43
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE             108.79
smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf_20250219154305        COMPLETE            3867.18
2020_CAPE_20250219154305                                           COMPLETE              39.81
2020_easter_storm_20250219154306                                   COMPLETE              41.14
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE           14805.79

@MichaelLueken
Copy link
Collaborator Author

The coverage WE2E were successfully run on Gaea-C5 manually running the updated Jenkins scripts:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
community_20250220141043                                           COMPLETE              66.91
custom_ESGgrid_NewZealand_3km_20250220141044                       COMPLETE             203.51
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              88.15
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20250220141  COMPLETE              88.57
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2025022014  COMPLETE              91.84
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             761.08
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025022  COMPLETE              88.89
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             724.31
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              30.49
2020_CAPE_20250220141106                                           COMPLETE             106.24
2020_easter_storm_20250220141108                                   COMPLETE             101.91
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2351.90

@RatkoVasic-NOAA
Copy link
Collaborator

And here is from Orion:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              17.73
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE              12.05
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              41.03
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025022  COMPLETE              60.66
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250220110  COMPLETE              32.82
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025022011100  COMPLETE              80.00
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             244.29

@EdwardSnyder-NOAA
Copy link
Collaborator

I opened a PR to this branch that will allow the SD WE2E to run on NOAA Cloud. I tested these changes on GCP and all tests have passed including the SD.

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              19.18
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE              14.46
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              29.57
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025022  COMPLETE              45.62
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250220211  COMPLETE              29.47
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025022021132  COMPLETE              50.06
smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf_20250220211327        COMPLETE            1885.07
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2073.43

@EdwardSnyder-NOAA EdwardSnyder-NOAA self-requested a review February 21, 2025 15:22
Copy link
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes on NOAA Cloud and the Gaea name changes look good to me. Approving.

@MichaelLueken
Copy link
Collaborator Author

@EdwardSnyder-NOAA Thank you very much for the NOAA Cloud testing and approval!

@RatkoVasic-NOAA Thank you very much for running the tests on Orion! Please let me know if there are additional tests that you would like for me to run or if you are running more tests. If you are happy with the update, I'd greatly appreciate it if you would be able to approve this PR!

Thanks again!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Feb 21, 2025
@MichaelLueken
Copy link
Collaborator Author

All coverage WE2E tests have successfully passed. Merging PR now.

@MichaelLueken MichaelLueken merged commit 1d252b0 into ufs-community:develop Feb 21, 2025
5 of 6 checks passed
mkavulich pushed a commit to mkavulich/ufs-srweather-app that referenced this pull request Feb 21, 2025
…smoke/dust WE2E test to testing suites (ufs-community#1195)

* Update weather model hash to 8933749 from February 19, 2025
* Add smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf WE2E test to coverage.gaea-c6, comprehensive and comprehensive.orion (sym linked to comprehensive.gaea-c6 and comprehensive.hercules)
* Update modulefiles/build_hera_gnu.lua to allow smoke and dust WE2E test to run on Hera GNU.
* Address documentation failures now that https://www.fvcom.org site's security certificate has been renewed
* Change gaea to gaeac5 and gaea-c6 to gaeac6 throughout to address node name change in Jenkins
* Remove Jet support in Jenkins

---------

Co-authored-by: EdwardSnyder-NOAA <[email protected]>
@MichaelLueken MichaelLueken deleted the feature/hash_update_02_2025 branch February 25, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants