-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Feature cicd scorecard metric #1079
[develop] Feature cicd scorecard metric #1079
Conversation
…p-Raytheon/ufs-srweather-app into feature/cicd_scorecard
[develop] Update nco version (ufs-community#1077)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. The srw_test.sh passed on PW AWS and the expt can be found here: /contrib/Edward.Snyder/ss-ci/ufs-srweather-app/expt_dirs/grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0
To run the srw_test.sh these variables were exported:
- export WORKSPACE=$PWD
- export SRW_PLATFORM=noaacloud
- export SRW_COMPILER=intel
- export SRW_PROJECT=ca-epic
- export SRW_WE2E_COMPREHENSIVE_TESTS=FALSE
- export SRW_WE2E_SINGLE_TEST=skill-score
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. I was also able to successfully run the coverage tests using the Jenkins scripts on Hera Intel:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
custom_ESGgrid_Peru_12km_20240424161412 COMPLETE 29.64
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200_2024042 COMPLETE 5.91
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2 COMPLETE 1436.48
get_from_HPSS_ics_HRRR_lbcs_RAP_20240424161416 COMPLETE 14.37
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 5.93
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20 COMPLETE 12.60
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP_20240424161419 COMPLETE 9.85
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2_20240 COMPLETE 6.20
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_202404 COMPLETE 436.04
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_20240424 COMPLETE 577.13
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR_202404241 COMPLETE 870.05
pregen_grid_orog_sfc_climo_20240424161425 COMPLETE 7.54
----------------------------------------------------------------------------------------------------
Total COMPLETE 3411.74
and Jet:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
community_20240424163221 COMPLETE 19.09
custom_ESGgrid_20240424163223 COMPLETE 24.73
custom_ESGgrid_Great_Lakes_snow_8km_20240424163225 COMPLETE 23.12
custom_GFDLgrid_20240424163227 COMPLETE 10.40
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2021032018_202404 COMPLETE 11.63
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_netcdf_2022060112_48h_20 COMPLETE 80.78
get_from_HPSS_ics_RAP_lbcs_RAP_20240424163230 COMPLETE 17.00
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20240424163232 COMPLETE 627.43
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20 COMPLETE 65.27
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 9.09
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_2024 COMPLETE 921.15
----------------------------------------------------------------------------------------------------
Total COMPLETE 1809.69
Approving PR now.
The Jenkins tests successfully passed for Derecho, Gaea, Hera GNU, Hera Intel, and Hercules. There are currently issues with the Jenkins runner on Jet, but I was able to successfully run the coverage tests manually on Jet yesterday as part of my review. The nodes on Orion are currently down due to a cooling issue that was encountered last night. I will now go ahead and merge this PR. |
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
Three separate runs to verify SUCCESS even without executing all E2E tests
I. Fundamental Tests
II. skill-score test only
III. none
DEPENDENCIES:
DOCUMENTATION:
No new changes to the way the Jenkins job is launched.
ISSUE:
The previous update to Jenkinsfile added a trigger to another job that collects metrics of all the target platforms. It was initially in a final stage of the pipeline, but needs to only be in the post() section of the pipeline so that it is only triggered once at the end.
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
Edward Snyder