-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define shared variables and predefined grids for all tasks #654
Comments
@danielabdi-noaa, can we change the NWGES name so it's more descriptive? What is the purpose of this directory? |
@JeffBeck-NOAA The use of NWGES is a bit of a legacy variable name in production. It is often used to define a directory holding DA-relevant files (such as first guess and analysis files) outside of the main COM output directory. It could be changed, but not sure if that would negatively impact those in GSL/EMC that deal with the DA aspects of RRFS. |
Thanks @MatthewPyle-NOAA! Got it. I suppose if we have sufficient documentation regarding these NCO-based variable/directory names in the SRW App, that would work too. |
Since RRFSv1 will not be released using the ufs-srweather-app repository, and the RRFS-related features have been removed from the SRW App repository following the merging of PR #893, I will now close this issue. |
Description
RRFS_dev1
tasks share a number of variables and predefined grids, so I believe these should go in before any task specific PR. I don't think it is appropriate to add these common things with a PR meant specifically for a given task. Examples:new NCO directory names
NWGES
,RRFSE_NWGES
,ENSCTRL_COMIN
TAG
variable that is prepended to all task names so that one can identify tasks in multiple workflowsWorkflow control flags such as
DO_SPINUP
,DO_DACYCLE
etcRRFS_dev1
defines a bunch of new cycles besidesforecast
,initial
etc,Add namelists for DA cycle
Maybe also add the workflow and test case? That will make sure the PRs are tested as they are added sequentially.
I think this PR is high priority because of this since all other tasks will depend on it. It can also serve as a base to develop the new yaml workflow since the cycles, workflow controls, new directories etc are all required
Solution
Modify
config_defaults.yaml
andpredef_grid_params.yaml
to include the above variables and new predefined grids respectively.Requirements**
None
Acceptance Criteria (Definition of Done)
Has the common variables for all tasks and new predefined grids.
Dependencies (optional)
None
The text was updated successfully, but these errors were encountered: