Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate all RRFS_dev1 variables and workflow configurations #538

Closed
danielabdi-noaa opened this issue Jan 16, 2023 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@danielabdi-noaa
Copy link
Collaborator

danielabdi-noaa commented Jan 16, 2023

Description

A lot of variables and workflow tasks are added in RRFS_dev1 that need to be incorporated back into SRW app. One can not test new j-job and ex-scripts of RRFS_dev1 in SRW app because it does not have all of them. The RRFS_dev1 workflow xml file is one big mess. That coupled with new tasks from the Air-Quality modelling work that @chan-hoo is working on, I see will be a problem. I am not offering a solution for this but @christinaholtNOAA may have a solution for that. Until then, we import all variables and workflow tasks to RRFS_dev1 so that new RRFS_dev1 tasks can be developed and tested in SRW.

Solution

Incorporate all new variables in config_defaults.yaml and all the tasks in FV3LAM_wflow.xml. Variables should have some structure f.i. new tasks should have own set of variables under a new section task_{new_task_name}. The first priority is to make sure current SRW app tasks work after RRFS_dev1 workflow incorporation. Provide flags to turn on/off flags for new spinup/prod cycle tasks etc. of RRFS_dev1.

Second, add capability to run and generate RRFS workflow for retrospective and realtime runs. Provide a config.rrfs.yaml file with RRFS_CONUS_3km domain that will be used for incorporating RRFS_dev1 tasks one by one.

Requirements**

None

Acceptance Criteria (Definition of Done)

  • Current SRW we2e tests must all pass
  • All new variables added in config_defaults.yaml and machine specific ones
  • All new workflow tasks added to FV3LAM_wflow.xml
  • Provide a config.rrfs.yaml file for development
  • RRFS_dev1 workflow generation should be possible in SRW app
@christinaholtNOAA
Copy link
Collaborator

It seems that we might want to address the variables needed for RRFS tasks one task at a time, where we can. As we add a new task to develop, we can assess what that one needs, and as you suggest, we can add a section to the config files.

@christinaholtNOAA christinaholtNOAA moved this from In Progress to Todo in RRFS Merge to SRW Feb 16, 2023
@danielabdi-noaa danielabdi-noaa moved this from Todo to In Review in RRFS Merge to SRW Mar 14, 2023
@danielabdi-noaa danielabdi-noaa moved this from In Review to PRs in RRFS Merge to SRW Mar 15, 2023
@christinaholtNOAA christinaholtNOAA moved this from PRs to In Review in RRFS Merge to SRW Mar 20, 2023
@christinaholtNOAA christinaholtNOAA moved this from In Review to On Hold in RRFS Merge to SRW Mar 20, 2023
@christinaholtNOAA christinaholtNOAA moved this from On Hold to In Review in RRFS Merge to SRW Apr 3, 2023
@christinaholtNOAA
Copy link
Collaborator

Take a look at this one after develop is merged with XML YAML.

@christinaholtNOAA christinaholtNOAA moved this from In Review to Done in RRFS Merge to SRW Apr 24, 2023
@christinaholtNOAA
Copy link
Collaborator

Suspending development of RRFS GSI capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants