Remove PIO as part of S2S model build in CMEPS and use hpc-stack #199
Conversation
|
@arunchawla-NOAA didn't you request that PIO was built internally to CMEPS and not as an external library for ease of code delivery, as @rsdunlapiv mentioned in the issue #197 |
|
Yes, we initially planned to have pio built as part of the model, but since pio is going to be used in multiple softwares we will get it installed as a library and have it included in WCOSS and RDHPCS |
|
@aerorahul, we just had an s2s commit, would you please merge with the latest s2s, then we can run RT? |
|
@aerorahul, The regression tests have been run on Hera, Orion and WCOSS Dell 3. The log files are located at /scratch1/NCEPDEV/nems/Bin.Li/S2S/update/log_files_PR199. |
@binli2337 |
|
@aerorahul Please try again. Thanks! |
that worked. thanks @binli2337 |
| @@ -16,8 +16,8 @@ | |||
| branch = master | |||
| [submodule "CMEPS"] | |||
| path = CMEPS | |||
| url = https://github.com/NOAA-EMC/CMEPS.git | |||
| branch = emc/develop | |||
| url = https://github.com/aerorahul/CMEPS.git | |||
There was a problem hiding this comment.
Sorry if I missed something, is it intentional to point to @aerorahul's CMEPS repo in the merged version of the code?
There was a problem hiding this comment.
No. not intentional.
There was a problem hiding this comment.
There is a PR in CMEPS. NOAA-EMC/CMEPS#16
Are they waiting for that one to merge?
I don't know how this works across repos.
There was a problem hiding this comment.
sorry I missed that merge. It is ready now.
There was a problem hiding this comment.
Usually it works the other way round, from bottom (innermost nested submodule) to top. Someone merges cmeps, you update your submodule pointer in your ufs-s2s-model PR to point back to the (now merged) official cmeps repo, then merge ufs-s2s-model.
There was a problem hiding this comment.
@climbfuji
What do you want me to do now?
Should I open another PR in ufs-s2s-model with the updated .gitmodules and the submodule pointer?
There was a problem hiding this comment.
@aerorahul Please submit a new PR. Thanks!
There was a problem hiding this comment.
New PR issued. See #205
* Use hpc-stack libraries in ufs-s2s-model (ufs-community#191) * Update .gitmodules and submodule pointer for fv3atm for PR ufs-community#157 (RRTMG cloud overlap method update) (ufs-community#193) * Bugfix/wave1dtest (ufs-community#195) * fix MOM6 input template used by the cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt test * Remove PIO as part of S2S model build in CMEPS and use hpc-stack (ufs-community#199) * update CMEPS submodule pointer (ufs-community#205) * Merge with upstream and fix conflicts Co-authored-by: BinLi-NOAA <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Denise Worthen <[email protected]> Co-authored-by: Rahul Mahajan <[email protected]>
* update to latest WW3, * update to latest NEMS and stochastic physics branches * point to new baseline in rt.sh * wcoss_dell_p3 log, wcoss_cray log, hera.intel log,* orion.intel log
Description of changes
This PR:
Specific notes
Issues Fixed (include github issue #):
closes #197
Are changes expected to change answers?
Specific changes:
Testing performed:
Hashes used for testing:
Co-authored by:
Associated PRs:
CMEPS PR #16
#199