NCAR-main PR#956 #38
Merged
NCAR-main PR#956 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2023 11:25
dustinswales
requested review from
grantfirl and
ChunxiZhang-NOAA
as code owners
37 tasks
ChunxiZhang-NOAA
approved these changes
Feb 10, 2023
|
@grantfirl please, go ahead to approve on this pr as well. |
|
@dustinswales still need to sync all the way up to downstream branches though. |
grantfirl
approved these changes
Feb 27, 2023
… into ncar-main-PR956
|
@jkbk2004 All up to date and synced |
|
Hi, @ChunxiZhang-NOAA . Tests are done on PR 1604, can you merge this PR? |
|
@grantfirl if possible, can you go ahead to merge the pr? |
|
@jkbk2004 Sorry, I missed this somehow. Thanks @grantfirl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is identical to NCAR #956
This PR addresses several outstanding issues:
Along with the physparam.f cleanup in Get rid of physparam.f (but not LTP) NCAR/ccpp-physics#488, instances of physcons.f were removed for the touched subroutines, mostly the rrtmg radiation.