Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nav-bar scaling in "tablet" sized screens #35

Closed
dylanalvarez1 opened this issue Sep 19, 2018 · 7 comments
Closed

Fix nav-bar scaling in "tablet" sized screens #35

dylanalvarez1 opened this issue Sep 19, 2018 · 7 comments

Comments

@dylanalvarez1
Copy link
Contributor

Fix visual issue where the nav-bar is too obstrusive in a certain range of screen dimensions such as medium sized screens (600 x 900 for example).

To Reproduce
Go to browser dev tools, and change the screen size to 600 x 900.

Expected behavior
Rearrange the nav-bar so it displays the different options in a less obtrusive way.

Screenshots
image

@mirdaki
Copy link
Member

mirdaki commented Oct 29, 2018

The eventual goal is to have the menu hover over the content (instead of push it down), kind of like this
image

@ZPPD
Copy link
Contributor

ZPPD commented Feb 12, 2019

Can I get this issue?

@mirdaki
Copy link
Member

mirdaki commented Feb 12, 2019

@ZPPD Sure! Let us know if you have any questions or suggestions

@ZPPD
Copy link
Contributor

ZPPD commented Feb 12, 2019

Thanks @mirdaki . I can't assign myself, but I will work on it tomorrow

@ZPPD
Copy link
Contributor

ZPPD commented Feb 13, 2019

@mirdaki
I am testing it on Chrome and Firefox. There is an empty div with a class of topnav-placeholder.
On the left is Firefox, where I have removed the empty div. On the right is Chrome with the empty div, which has a height of 60px.
Do you want me to keep the div? And is this what you are looking for for the design?

club-website-menu

@mirdaki
Copy link
Member

mirdaki commented Feb 14, 2019

Sorry for not getting back sooner. I feel like the left without the div looks the best! Thank you for your help

@mirdaki mirdaki modified the milestones: 1.1.0, 1.0.2 Feb 14, 2019
@mirdaki
Copy link
Member

mirdaki commented Feb 15, 2019

Fixed with #63

@mirdaki mirdaki closed this as completed Feb 15, 2019
@mirdaki mirdaki mentioned this issue Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants