[Bug]: Unexpected behaviour of configured extensions

[yurtsiv]

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.2.4

What’s the bug you are facing?

It applies to all methods in the extension config, but I'll give an example I stumbled upon with addProseMirrorPlugins

const Base = Extension.create(...)

const pluginKey = new PluginKey("someKey");

const Example = Base.extend({
  addProseMirrorPlugins() {
    return [
      ...(this.parent?.() ?? []),
      new Plugin({ key: pluginKey }),
    ]
  },
})

new Editor({
   extensions: [
      Example.configure()
   ]
})

Crashes with RangeError: Adding different instances of a keyed plugin (someKey$).

It happens because .configure() extends, so we end up with the hierarchy ExampleBase -> Example -> Example instead of ExampleBase -> Example which results in duplicate plugins being registered.

The same problem occurs with other methods, but those that return lists are most vulnerable (e.g. addInputRule).

I guess .configure() should copy the extension instead of extending it.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

No duplicate plugins are registered.

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[yurtsiv]

Related #4704

[yurtsiv]

This commit fda6310 seems to be the reason why it broke. Before it .extend() wasn't copying the config so the last extension in the hierarchy ExampleBase -> Example -> Example (described above) didn't have addProseMirrorPlugins and other methods defined.

Still, I believe .configure() should copy the extension instead of extending it.

[nperez0111]

This should be fixed with version 2.4.0, feel free to try it out!