fix: fix a bug in link click handler, where we can’t click on text se…

…lections. fix #263
ueberdosis · Apr 11, 2021 · 33c30c0 · 33c30c0
1 parent 703afe9
commit 33c30c0
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
@@ -103,14 +103,15 @@ export const Link = Mark.create<LinkOptions>({
         props: {
           handleClick: (view, pos, event) => {
             const attrs = this.editor.getMarkAttributes('link')
+            const link = (event.target as HTMLElement)?.closest('a')
 
-            if (attrs.href && event.target instanceof HTMLAnchorElement) {
+            if (link && attrs.href) {
               window.open(attrs.href, attrs.target)
 
-              return false
+              return true
             }
 
-            return true
+            return false
           },
         },
       }),